[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2] x86emul: Zero-extend unsigned 8-bit immediates when decoding


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Stephen Cheng <stephen.cheng@xxxxxxxxxx>
  • Date: Mon, 16 Nov 2026 09:27:48 +0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wb7wh6Q9/ERirblZ6aiEJ4Zf0zmrSV1CngOKyS5TOoM=; b=BTIMQLKlO3/Bni55yg/2lfTbH0dz5+/MKWyLDCLBoK/hRUYHxF1q1tFHdr3b+iSQ8X87h3yD8GV1Zek7LCkOqdbJy6vodnUpQvFoYSybx2m35mtq4NoGLlDEyMglz3rcdY8SwY1sXsKWaQoUBaREhnuA19ygJlzcbI9w+V37ygfvZX4p9svToVGCQ4gq0Y5oylurZGtzW1UEHMtGSMFjzlRKNTfYFr+qKtvuO2o6zsgVxjnQK3ivrFQMMgR1HZhxilH5HbnZwOdDURiqQtCIgs1DoUyi9Y12hpdv3Y9yGnuii15QTnZwOh5uPPos+IrQMMH/JCwr+9H4BK0NviCXag==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j0RDMP+4sP9x0ymItBjGPK6qwEfzWiVpBlM7656pd8zHtme0pGNnhNtUDabKZASYJghuK+5AbGLUbB40xogpyVC8DuQpgXSggCg30XuU6qwuHcrQFdXmR4/e9r7AH6wfGrNgRYkZU26PbbmsPhTSGBTsO1394+THTqNCYupypUskyypOaCEXe+9JKIaYrPGV20fpqnJ3YkGRir3QRXM203Iwzu9X3ZxnVshF3iPBH/KpxPcbwk7n0NZ8qkGkmd6WwtwX62CakOuMRzrc59AKfh2ogxkkyTDI0NfzA8HxDDGccr3+IvVd3ooiwpPZh84PmaRJ5vEJfRimSsnh10sodg==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Stephen Cheng <stephen.cheng@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
  • Delivery-date: Mon, 16 Nov 2026 01:30:15 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

The decoder sign-extends all 8-bit immediates. This is right for e.g.
Jcc rel8 and Grp1 (83), but some 8-bit immediates are unsigned: the
vector of INT, the port of IN/OUT, the base of AAM/AAD, the count of
the Grp2 shifts (C0, C1), and the 8-bit immediates in the 0F, 0F3A and
XOP08 maps. For these, s->imm1 holds a wrong value for 0x80 and above.
x86_insn_immediate() can return this value too.

The worst case is INT $0x80 to INT $0xff, which puts a negative vector
into the event (e.g. -128 for 0x80). hvm_inject_event() then fails its
"vector == event->vector" assertion, and a debug Xen panics. An HVM
guest can trigger this with the forced emulation prefix (hvm_fep).

Zero-extend these immediates in the decoder, and drop the (uint8_t)
casts at the IN/OUT and AAM/AAD use sites, which are not needed any
more.

Fixes: 653cae725cea ("x86/32on64: use generic instruction decoding for call 
gate emulation")
Fixes: 52053d5fc2f9 ("x86/emul: Drop swint_emulate infrastructure")
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Stephen Cheng <stephen.cheng@xxxxxxxxxx>
---
v2:
 - Fix this in the decoder instead of at the INT use site, and also cover
   the IN/OUT, AAM/AAD and C0/C1 immediates, plus the 0F, 0F3A and XOP08
   maps (Jan).
 - Drop the (uint8_t) casts at the IN/OUT and AAM/AAD use sites (Jan).
 - Add a Fixes: tag for the commit that added x86_insn_immediate() (Jan).
 - Drop Ross's R-b (patch changed a lot).

v1: 
https://lore.kernel.org/xen-devel/20261112072303.86955-1-stephen.cheng@xxxxxxxxxx/

Note: While fixing this bug, I found a separate, older one. BT{,S,R,C}
with an imm8 bit offset and a memory operand move the memory address by
the immediate. The CPU doesn't do this: it uses the immediate modulo the
operand size, at the same address. See Intel SDM (325462-092US, June
2026) Vol 2A, section 3.1.1.9 "Operation Section", Table 3-2 "Range of
Bit Positions Specified by Bit Offset Operands", and "BT-Bit Test".
So any immediate >= 32 (for 32-bit operands) accesses the wrong memory.
E.g. with FEP, btsl $0xff,(%rdi) sets a bit at rdi-4 before this patch
and at rdi+28 after it, but the CPU uses rdi. I'll send a separate fix
for this.

 xen/arch/x86/x86_emulate/decode.c      | 15 ++++++++++++++-
 xen/arch/x86/x86_emulate/private.h     |  2 +-
 xen/arch/x86/x86_emulate/x86_emulate.c |  4 ++--
 3 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/x86_emulate/decode.c 
b/xen/arch/x86/x86_emulate/decode.c
index c4b18718f8..a8129de672 100644
--- a/xen/arch/x86/x86_emulate/decode.c
+++ b/xen/arch/x86/x86_emulate/decode.c
@@ -650,10 +650,19 @@ decode_onebyte(struct x86_emulate_state *s,
     case 0xc4: /* les */
     case 0xc5: /* lds */
     case 0xce: /* into */
+    case 0xd6: /* salc / udb */
+        s->not_64bit = true;
+        break;
+
     case 0xd4: /* aam */
     case 0xd5: /* aad */
-    case 0xd6: /* salc / udb */
         s->not_64bit = true;
+        fallthrough;
+    case 0xc0: case 0xc1: /* Grp2 */
+    case 0xcd: /* int imm8 */
+    case 0xe4 ... 0xe7: /* in/out imm8 */
+        /* The 8-bit immediate is unsigned. */
+        s->imm1 = (uint8_t)s->imm1;
         break;
 
     case 0x82: /* Grp1 (x86/32 only) */
@@ -1796,6 +1805,8 @@ int x86emul_decode(struct x86_emulate_state *s,
         break;
 
     case ext_0f:
+        if ( (d & SrcMask) == SrcImmByte )
+            s->imm1 = (uint8_t)s->imm1;
         rc = decode_twobyte(s, ctxt, ops);
         break;
 
@@ -1804,6 +1815,7 @@ int x86emul_decode(struct x86_emulate_state *s,
         break;
 
     case ext_0f3a:
+        s->imm1 = (uint8_t)s->imm1;
         d = ext0f3a_table[b].to_mem ? DstMem | SrcReg : DstReg | SrcMem;
         if ( ext0f3a_table[b].two_op )
             d |= TwoOp;
@@ -1814,6 +1826,7 @@ int x86emul_decode(struct x86_emulate_state *s,
         break;
 
     case ext_8f08:
+        s->imm1 = (uint8_t)s->imm1;
         d = DstReg | SrcMem;
         if ( ext8f08_table[b].two_op )
             d |= TwoOp;
diff --git a/xen/arch/x86/x86_emulate/private.h 
b/xen/arch/x86/x86_emulate/private.h
index 7892b5603b..b2997b20cd 100644
--- a/xen/arch/x86/x86_emulate/private.h
+++ b/xen/arch/x86/x86_emulate/private.h
@@ -62,7 +62,7 @@ void BUG(void);
 #define SrcMem      (2<<3) /* Memory operand. */
 #define SrcMem16    (3<<3) /* Memory operand (16-bit). */
 #define SrcImm      (4<<3) /* Immediate operand. */
-#define SrcImmByte  (5<<3) /* 8-bit sign-extended immediate operand. */
+#define SrcImmByte  (5<<3) /* 8-bit immediate operand. */
 #define SrcImm16    (6<<3) /* 16-bit zero-extended immediate operand. */
 #define SrcMask     (7<<3)
 /* Generic ModRM decode. */
diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c 
b/xen/arch/x86/x86_emulate/x86_emulate.c
index f168f3ebcf..da7e9753ce 100644
--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -2505,7 +2505,7 @@ x86_emulate(
 
     case 0xd4: /* aam */
     case 0xd5: /* aad */
-        n = (uint8_t)src.val;
+        n = src.val;
         if ( b & 0x01 )
             _regs.ax = (uint8_t)(_regs.al + (_regs.ah * n));
         else
@@ -2561,7 +2561,7 @@ x86_emulate(
     case 0xed: /* in %dx,%eax */
     case 0xee: /* out %al,%dx */
     case 0xef: /* out %eax,%dx */ {
-        unsigned int port = ((b < 0xe8) ? (uint8_t)src.val : _regs.dx);
+        unsigned int port = ((b < 0xe8) ? src.val : _regs.dx);
 
         op_bytes = !(b & 1) ? 1 : (op_bytes == 8) ? 4 : op_bytes;
         if ( (rc = ioport_access_check(port, op_bytes, ctxt, ops)) != 0 )
-- 
2.49.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.