[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC v2 17/42] securityfs: use fc_init_pseudo()
- To: Christian Brauner <brauner@xxxxxxxxxx>
- From: Chris Down <chris@xxxxxxxxxxxxxx>
- Date: Sat, 14 Nov 2026 12:05:55 -0800
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=chrisdown.name header.i="@chrisdown.name" header.h="User-Agent:Message-ID:Content-Disposition:Content-Type:MIME-Version:References:In-Reply-To:Subject:Cc:To:From:Date"
- Cc: linux-fsdevel@xxxxxxxxxxxxxxx, Jann Horn <jannh@xxxxxxxxxx>, Chris Mason <mason@xxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, driver-core@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, bpf@xxxxxxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, selinux@xxxxxxxxxxxxxxx, apparmor@xxxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, fuse-devel@xxxxxxxxxxxxxxx, linux-efi@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, Amir Goldstein <amir73il@xxxxxxxxx>, linux-erofs@xxxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx, Alexander Mikhalitsyn <alex@xxxxxxxxxxxx>
- Delivery-date: Sun, 15 Nov 2026 10:13:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Christian,
Christian Brauner writes:
AppArmor puts a .null device node into securityfs but only ever opens
it via dentry_open() which doesn't care about SB_I_NODEV.
Not a big deal, but userspace can see that node too, as
/sys/kernel/security/apparmor/.null. Opening it by path works in current
kernels and fails with EACCES after this patch. Now, I don't know of
anything that does that, but selinuxfs gets SB_I_NODEV cleared again in
the next patch for the same kind of node, so I think we should do the
same thing here. If not, it would be good to have a line in the
changelog saying that opening it by path is meant to stop working.
Once that's fixed, please feel free to add:
Reviewed-by: Chris Down <chris@xxxxxxxxxxxxxx>
|