[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] Eclair: scan the last xen-syms linking pass on Arm
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
- Date: Mon, 19 Oct 2026 11:02:25 +0300
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=THqUcA+jSlE+cJXyOzAplOpsf2pkcu16YpV0TJNMB/w=; b=cHU7kJvdPF/2mmIJRpXw/SY0s/tFqHm49ZCCWZIRXO1UaUC2Ze/JUUWujt/gxBE5bsxPf1M2i33iH5O2mn132AVohDzSxrIMx8Y+CxoW6Fs4PBXeUgw0VAvLn6vXDEhiPxBSJOzFuLXKxfp+i9ALJL8XVs/QBDLpcXXEqucJHa9E5l+aMXWnqKQTiKfNXAa+3XZwTTBxVCCKF404LfQJd66OV3xnYnu6BmuvkfrmxPH0JFco3/jP2VpEnlUgkCYD5ns3hLrASFgGLSKyNAI3DLFUaMFtymF5L6VPH/swNwuKzjZ32+fBv65IteqHof4bauIF7JvgLMqmypGjz9b9Cw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wZi9tE9eyt6Ww5mQRX/J4uSvX31VACoLOJ9NkJN+b17zDeDHxj0pXHg65q4XL1F49WkFWAi14eDJEnW1eZk3GEnVrBynHRMj85gI1aFCUdJ57/EgnEBlsAq/yr6VV9W8P23ExcoOVw7vKg3jb6jpYUG5MR0a+uI1WzCMTfBrrE5G5B4vWLK6jN8+6BQRPgZyOHpzJ+UASvv33wb3b9d0BZ8Ns/H2f/9KYCg76htn2Tfgyuj76M0D3P3+VSgjatBoDfYVB6tEQcw6XCDRQH463FM1BS14tMZMR7s4k/JcOYMSG5cfdwvOoNAPavqYIALluyFbfpQh+hc+dDqTjEkfIg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 19 Oct 2026 08:02:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/13/26 11:14, Jan Beulich wrote:
On 13.10.2026 10:02, Dmytro Prokopchuk1 wrote:
On 10/13/26 10:52, Jan Beulich wrote:
On 12.10.2026 22:49, Dmytro Prokopchuk1 wrote:
--- /dev/null
+++ b/automation/eclair_analysis/ECLAIR/generate-xen-syms-passes.sh
You neatly use dashes in the new file's name here. Is there a reason ...
@@ -0,0 +1,20 @@
+#!/bin/bash
+
+# Hide every xen-syms linking pass except LAST_LINKING_PASS.
+# The pass list is the foreach in xen/scripts/Makefile.link.
+
+set -e
+
+cd "$(dirname "$0")"
+arch=$(echo "${XEN_TARGET_ARCH}" | sed -e 's/x86.*/x86/' -e 's/arm.*/arm/')
+last=$(sed -n 's/^LAST_LINKING_PASS *:= *\([0-9]\).*/\1/p' \
+ "../../../xen/arch/${arch}/Makefile" | head -n 1)
+passes=$(sed -n 's/.*foreach n,\([0-9 ]*\).*/\1/p' \
+ ../../../xen/scripts/Makefile.link | head -n 1)
+test -n "${last}"
+test -n "${passes}"
+hidden=$(printf '%s' "${passes}" | tr -d " ${last}")
+
+printf '%s\n' \
+ "-file_tag+={xen_syms_tmp, \"^xen/\\\\.xen-syms\\\\.[${hidden}]\$\"}" \
+ >xen_syms_passes.ecl
... underscores are used here?
The generated file follows the other .ecl names (e.g.
linker_symbols.ecl). The script name follows generate-linker-symbols.sh,
which also uses dashes and writes an .ecl file with underscores.
That's not very nice, but otoh not as problematic to warrant an immediate
change. At the same time here your use of underscores is not only a style
issue (where bad pre-existing instances should never be used as an excuse),
but also weakens the connection to xen-syms: The underscore used could in
principle be a surrogate for about any non-alnum character, including e.g.
a dot.
Jan
I agree the underscores make the link to xen-syms less obvious.
Since you don't see it as blocking, I'd prefer to leave the names as
they are for consistency with the existing files. If you'd like to
rename it (e.g. xen-syms-passes.ecl), I can do that in a follow-up.
BR, Dmytro
|
