Re: [PATCH v3] Eclair: scan the last xen-syms linking pass on Arm

[Jan Beulich <jbeulich@xxxxxxxx>]

On 13.10.2026 10:02, Dmytro Prokopchuk1 wrote:
> On 10/13/26 10:52, Jan Beulich wrote:
>> On 12.10.2026 22:49, Dmytro Prokopchuk1 wrote:
>>> --- /dev/null
>>> +++ b/automation/eclair_analysis/ECLAIR/generate-xen-syms-passes.sh
>>
>> You neatly use dashes in the new file's name here. Is there a reason ...
>>
>>> @@ -0,0 +1,20 @@
>>> +#!/bin/bash
>>> +
>>> +# Hide every xen-syms linking pass except LAST_LINKING_PASS.
>>> +# The pass list is the foreach in xen/scripts/Makefile.link.
>>> +
>>> +set -e
>>> +
>>> +cd "$(dirname "$0")"
>>> +arch=$(echo "${XEN_TARGET_ARCH}" | sed -e 's/x86.*/x86/' -e 's/arm.*/arm/')
>>> +last=$(sed -n 's/^LAST_LINKING_PASS *:= *\([0-9]\).*/\1/p' \
>>> +    "../../../xen/arch/${arch}/Makefile" | head -n 1)
>>> +passes=$(sed -n 's/.*foreach n,\([0-9 ]*\).*/\1/p' \
>>> +    ../../../xen/scripts/Makefile.link | head -n 1)
>>> +test -n "${last}"
>>> +test -n "${passes}"
>>> +hidden=$(printf '%s' "${passes}" | tr -d " ${last}")
>>> +
>>> +printf '%s\n' \
>>> +    "-file_tag+={xen_syms_tmp, \"^xen/\\\\.xen-syms\\\\.[${hidden}]\$\"}" \
>>> +    >xen_syms_passes.ecl
>>
>> ... underscores are used here?
> 
> The generated file follows the other .ecl names (e.g. 
> linker_symbols.ecl). The script name follows generate-linker-symbols.sh, 
> which also uses dashes and writes an .ecl file with underscores.

That's not very nice, but otoh not as problematic to warrant an immediate
change. At the same time here your use of underscores is not only a style
issue (where bad pre-existing instances should never be used as an excuse),
but also weakens the connection to xen-syms: The underscore used could in
principle be a surrogate for about any non-alnum character, including e.g.
a dot.

Jan