[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Eclair: scan the last xen-syms linking pass on Arm


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
  • Date: Tue, 6 Oct 2026 14:23:18 +0000
  • Accept-language: en-US, uk-UA, ru-RU
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CgShQoPWGyW24mcGZ9e2lq1F4W3v9OLSLZhEXQO5kQ4=; b=P8i4Vywt7ca9ucRD/vyyuF5Fx7gL7bALW5DhDuXX+bohzyPqKmX20Pn8ujIB7HQ/LfjNh3nxmdN/4GLsVMPQ0Lf5roXYSZLWWqTo+o8e2pdTPmPf/TM+UTdLAQC1l5T4pd1Rv86iC+sIODV5NUjPGkPPw1m5Z0JUZ5DpUt6Twn1GNauFzVBRSCzQaTdIIodEIkbaAWgzmoX3g+tllB4Nkkp2/S7SYgyH/BtLX3CvhVySjuERWE6IIz/yABOQ8EK4VvViAa39Jvki3uPTIZ1WRmZCCMk+oEn08ho6C2dHyY+qqpU6Vx/3kewodH8EgZBLxC9CCvFjMJ3/PT4Githncg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NT4ytPG+BkKkMz8EuA3XVt0lI8dhYmI5YCH08kt1KUpevGEnaEZYKRjLlx6XLDqW6y5SR8XeGjeRgRGskZ9f8W1TKMDFa8zz/ApYOvT3WV2nGEeaqGn/jRKMtstLsFGu5yYuMEZeRl8R21e9D6oq5ALy+Du+frVSmT80sbWqfMIVhxYlbh5VqCPbtgh4mHa9MuLwhSeRTdEfcNT1Lx1vOtSOQQ0gLlbZ5d4Z9Z01sU5CKKM4bc59CyKiy6tf2KL51IlScpdqFNSugvIHpXYOkkt4dgSVnhmIuYS+/HrKFORXqr1brBew9PkA/VBxoWG5BODilUvjXyFV29JMGOXq4A==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
  • Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Tue, 06 Oct 2026 14:23:37 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHdVZ47rgN8qfc/LUyZracn12XLUw==
  • Thread-topic: [PATCH] Eclair: scan the last xen-syms linking pass on Arm

Hiding .xen-syms.[013] assumed the almost-final image is always pass 2.
On x86 LAST_LINKING_PASS is 2, so .xen-syms.2 stays visible. On Arm
LAST_LINKING_PASS is 3 and the final image is .xen-syms.3, which was
hidden. Pass 2 is usually only a symlink, so Eclair saw no program link
and reported every translation unit as unreachable.

Stop hiding pass 3. Passes 0 and 1 remain excluded.

Fixes: a401b5c9dc35 ("Eclair: re-enable scanning of the (almost) final linking 
step")
Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
---
Test CI pipeline: 
https://gitlab.com/xen-project/people/dimaprkp4k/xen/-/pipelines/2918036491
---
 automation/eclair_analysis/ECLAIR/analysis.ecl | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/automation/eclair_analysis/ECLAIR/analysis.ecl 
b/automation/eclair_analysis/ECLAIR/analysis.ecl
index c6e1a7a95d..4078c14a3c 100644
--- a/automation/eclair_analysis/ECLAIR/analysis.ecl
+++ b/automation/eclair_analysis/ECLAIR/analysis.ecl
@@ -35,9 +35,11 @@ their Standard Library equivalents."
 -doc_end
 
 -doc_begin="Do not analyze intermediate linking artifacts, as they do not 
differ from their final
-counterparts for the purposes of MISRA C static analysis."
+counterparts for the purposes of MISRA C static analysis.
+The scanned xen-syms link is the last linking pass (.xen-syms.2 on x86, where
+that pass is final, .xen-syms.3 on Arm, where a further pass exists)."
 -file_tag+={xen_efi_tmp, "^xen/\\.xen\\.efi\\.([01]|alt\\..*)$"}
--file_tag+={xen_syms_tmp, "^xen/\\.xen-syms\\.[013]$"}
+-file_tag+={xen_syms_tmp, "^xen/\\.xen-syms\\.[01]$"}
 -frames+={hide, "kind(program)&&target(xen_syms_tmp||xen_efi_tmp)"}
 -doc_end
 
-- 
2.43.0



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.