[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/12] kexec: machine_reboot_kexec() doesn't return
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- Date: Mon, 5 Oct 2026 10:38:11 +0000
- Accept-language: en-US, uk-UA, ru-RU
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TJhOiI1D5xUBlpAiqrtu3EP57Qh8aYWsgMZ5he6gzp8=; b=o+MkHa52zY1pjP3wMzvkbVVdPGL361c07ezJPbKpN7mPtlEvNXptZNh47Qp9CyFoKayy6eM7+yRS+ZG+cxvwoWoDSlyjRw+S6J8LRInI94xcGpQr++SQtidjEGApGVvBuZBE6R68Yps2XxHBW1uvNKvsXuE8PHivTQbf+5jgQbCnRny/4MOBplM3Mvum8hefhl9B1x9q/lDc8leD/t+RT9odtcWu0ksEBC+ptlRfUb09iGMCSZRUL4XKI99kDyijUNOJdHQ7SsWkSDIlj/8DnBoY9g9F+Oz4X4PGOgyPfIEQIXXDykevwbyuvyhal7DfDKKNxf8HkTvmfqqFYMdGKA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CmIG3S9C4uubAXDt71hfImYoYbgsrEwkf8VUa8KIatATuBRpEBe2Ft+EvLfMGUjXklQt6vw/KFXsLOXYQp5mKMzCMQvBIj4z4pZa84JFwmsBM9xEGj54f1RINGwzZi1GxqvT7PehtyntcMoX0A4um0TJBccwLYh53tiJl4PtdO3U0k5wkSDtfbQgQERE0tpr2DW6lmwQGj6rMHyWzVLSNd3lQiKjRNdNmzI1iVuXGQc3pwu8/1yQLovOf3/m2ZyC35QSBBxEVmZwp2QdI+ibXTfS388gsOhmdi9nkPTuiik5b9cYr+7/8v2/sUiPmP+ntiPKqsd0/EMw87mX/w8/4w==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Delivery-date: Mon, 05 Oct 2026 10:38:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHdNrtNnuxIk3AqN0yIVRN5rIwRg7azOR0AgDvEqIA=
- Thread-topic: [PATCH 06/12] kexec: machine_reboot_kexec() doesn't return
On 8/28/26 12:55, Nicola Vetrini wrote:
> On 2026-08-28 09:02, Jan Beulich wrote:
>> Mark it as such, and then remove the code following at its sole call
>> site,
>> for Eclair flagging that as a Misra rule 2.1 (unreachable code)
>> violation.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>
> Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>
>> --- a/xen/common/kexec.c
>> +++ b/xen/common/kexec.c
>> @@ -401,7 +401,7 @@ void kexec_crash(enum crash_reason reaso
>> BUG();
>> }
>>
>> -static long cf_check kexec_reboot(void *_image)
>> +static long noreturn cf_check kexec_reboot(void *_image)
>> {
>> struct kexec_image *image = _image;
>>
>> @@ -409,9 +409,6 @@ static long cf_check kexec_reboot(void *
>>
>> kexec_common_shutdown();
>> machine_reboot_kexec(image);
>> -
>> - BUG();
>> - return 0;
>> }
>>
>> static void cf_check do_crashdump_trigger(unsigned char key)
>> --- a/xen/include/xen/kexec.h
>> +++ b/xen/include/xen/kexec.h
>> @@ -48,7 +48,7 @@ int machine_kexec_add_page(struct kexec_
>> int machine_kexec_load(struct kexec_image *image);
>> void machine_kexec_unload(struct kexec_image *image);
>> void machine_kexec_reserved(xen_kexec_reserve_t *reservation);
>> -void machine_reboot_kexec(struct kexec_image *image);
>> +void noreturn machine_reboot_kexec(struct kexec_image *image);
>> void machine_kexec(struct kexec_image *image);
>> void kexec_crash(enum crash_reason reason);
>> void kexec_crash_save_cpu(void);
>
LGTM.
Reviewed-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
|
