[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] vm_event: svm: Don't BUG() when enabling intercept on hypervisor MSR
- To: Teddy Astie <teddy.astie@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Thu, 24 Sep 2026 16:50:27 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vates.tech smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XrwXOGVPoCuvkbvKL3weAoNwHrYqs0UvPWiSsQhyNMA=; b=VvYuX1BmrRwNwHXwcBwKj9/s3boaaWy6W9RKP04oKGNUdlrIJJZ8xqjVzLX9Azk/6vWbC9Kwwt8yiQ9v9ATCJ4M395TOQvkPjotR+EbEzt1VXylULZV9KHUVINFG2OEpv6EJxcboo7U+2xIc27yTcypQCf1btgM6E6bnLDJX2yDrbsgiHAHAUzvjJXIKyXRE9a2CZaSYy9xAkyOMzWzrPbRJdYHFJL7CI2ApD+j+CB3lBCgQh7uUh21taBXeyQFM5ZYalpLiHLBprmJC3BW6oE7zRlg/4anr5sbrk4Q5SDiVHLrkUiF8FmLHIRrMv9pCTISGxadNZCsxkGrKlmqHSA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g0TnSY8VneubHBgeyhD1m8uEhNIg8U5WXBnSBj7obBu3+LyFZ91YkcpGa+Ok5i84mYBB2LvTvnn91Qbob/MVtLBQQEFQcfN0k4oEUX0xGIZbhLmeFfj6EuCxLJ2CCllT9OCvCiF6oJDq+baKfIZbWgvxBenIC1Io5Iy6E7FDvI9c7D9p0OBRewuImeVBx5cd2vxFizGtDHlqZlFsbyTWCaL52YBOsnjnU8Hkw6KQWFCzwNy/4ia6jofKcxRPNQ6NJnLa2ZdbyTxrvpiYqBn8JDYpRQxCdq5jPAhpoDg8Ci3JX+/guGyg08PB0jWUD8EUH3C3cN865YySBEGnvNqNhg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>
- Delivery-date: Thu, 24 Sep 2026 20:55:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-09-24 07:56, Teddy Astie wrote:
svm_msrbits() only cover MSRs in the ranges specified in APM and returns
NULL for all the other ones (i.e hypervisor range), which triggers the
BUG_ON() that follows.
APM specifies that MSR outside the architectural and AMD specific ranges
are unconditionally intercepted, hence don't require any specific handling
by SVM logic, fix this by ignoring cases when msr_bit is NULL.
This is only reachable with CONFIG_VM_EVENT using
XEN_DOMCTL_MONITOR_EVENT_MOV_TO_MSR
to configure a MSR intercept in the hypervisor range (0x40000000–0x40001fff).
Fixes: 6e9fc4d628b6 ("hvm/svm: Enable MSR events")
Signed-off-by: Teddy Astie <teddy.astie@xxxxxxxxxx>
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Thanks,
Jason
|
