[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] vm_event: svm: Fix incorrect monitored_msr() check
- To: Teddy Astie <teddy.astie@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Thu, 24 Sep 2026 16:51:24 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vates.tech smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2E/f0fpmXT0ZjsFoGXlxc/pgA8IpqgUbdIw6ulGug+Y=; b=AnayFr1PziNbSCtwF55RLXQjYQaS2ZatyMzDC+HCUfMkXXCX6DqufjggLtw45ie+HDs9seiS8ipSO4hqFQS3A9Hn9NQVzL7ezLXLc+QifDFpkEMkD6S/1PilFM2V7W8zR2e4YnBky2kuFHD7tBTronELcSZDtIM0JlRaywB/WaN2X7mghwx7po/CB3VlCEvQsmbLggvuLgdgo6CsS/qokgTt+GQ47adwEChCdNkQm4j/bypiKdSGYsTjY5d40il1VnuFkdmB6PgxZ5oO3UWTmj/UUpkWJKJAmsX6tjABPRPHuUCFyeWnzwZwRvwwM7zJWdtQCoqMHux911Y6o2F1Dw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NXWlg9Ga+C/vZdSkIbuf3xKsmQaUj/FPutWo9UNbbRvJZs+thX5yKEandiIna6uBGYgpVUO0HY8M+WmeFKtbmt02Re3xb25ubvdyGX/Yi89mblN2+zpPPtO3yokiiYNPEE8+SiXoV89uv+AShAa3VxMhsKAVjEvNF021sQdaLbJg9T6R4Ihb1pXhjASxgF3TIXW04K14f055HkfyqhdXEdfPa6TXTg5mpb8W2X+ImWFw6Mvj/g0AMTYRA973ncqbooPSiYumLTmMrxE4m8PSwijH0crxzmor4RvqGYU/6UHtyvl3m2j1EseoORIx8kNF67fqYJGLyirzs+bl7PcGUA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>
- Delivery-date: Thu, 24 Sep 2026 20:51:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-09-24 07:56, Teddy Astie wrote:
monitored_msr() is called with truncated MSR values (&= 0x1fff)
which doesn't match the original one, making the check incorrect.
Fix that by keeping the msr value intact and computing the bitmap
offset separately (in msr_offset).
Fixes: 2746088d9cb4 ("svm: don't clear interception for MSRs required for
introspection")
Signed-off-by: Teddy Astie <teddy.astie@xxxxxxxxxx>
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Nice find.
---
Should we multiply by 2 msr_offset instead of doing that in {set,clear}_bit() ?
If you do that, I suggest you use msrpm_offset as the name since it is
no longer the msr.
Regards,
Jason
|
