Re: [PATCH v2 2/7] Arm: split xen-syms linking rule

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Wed, Aug 26, 2026 at 02:00:55PM +0200, Jan Beulich wrote:
> Doing so, besides (hopefully) adding clarity (not the least by way of
> [re-]using pattern rules where possible), also avoids explicit recursive
> $(MAKE) invocations.
> 
> By re-using the generic rules introduced when the respective x86 rule was
> split,
> - the .map file now isn't created after the final binary anymore,
> - --strip-debug is passed to $(LD) during early linking passes (for
>   consistency the option is also explicitly added to the optional linking
>   pass rule),
> - CONFIG_{SUPPRESS_DUPLICATE_SYMBOL_WARNINGS,ENFORCE_UNIQUE_SYMBOLS} are
>   now properly respected.
> Orphan section checking, otoh, is getting suppressed for now, until the
> about a dozen warnings which would result have been taken care of.
> 
> While the 4th linking step continues to be avoided when possible, a
> redundant invocation of $(NM) and tools/symbols (plus the assembling of
> the resulting .S file) is hopefully deemed acceptable.

So with this patch, if .xen-syms.1.o and .xen-syms.2.o are the same
(compare-symbols-tables), we through away .xen-syms.2.o, and build
.xen-syms.3.o from .xen-syms.1 (nm|symbols + as). I guess the resulting
.xen-syms.3.o would be the same as .xen-syms.2.o, so it's probably fine.


I think this patch is fine, I didn't find other difference in command
executed beside the one described in the patch description:

Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,


--
Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech