Re: [PATCH] x86/alternatives: mark .altinstructions r/w

[Roger Pau Monné <roger@xxxxxxxxxxxxxx>]

On Wed, Sep 02, 2026 at 10:31:56AM +0200, Jan Beulich wrote:
> On 02.09.2026 09:27, Roger Pau Monné wrote:
> > On Wed, Sep 02, 2026 at 09:15:46AM +0200, Jan Beulich wrote:
> >> Forever since the introduction of the .priv member it has been wrong to
> >> record the section as r/o.
> >>
> >> .alt_call_sites, otoh, is legitimately r/o, hence
> >> __alt_call_sites_{start,end}[] would better reflect that.
> > 
> > Right, we don't however have a .init.rodata section, and hence it gets
> > placed in the .init.data section which is r/w.  No objection about the
> > addition of const, it's the right thing.
> > 
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > 
> > Acked-by: Roger Pau Monné <roger@xxxxxxxxxxxxxx>
> 
> Thanks.
> 
> > I think you want:
> > 
> > Fixes: 4008c71d7af2 ("x86/alt: Support for automatic padding calculations")
> 
> I was pondering to add this, but then decided against (it's an inconsistency,
> not really a bug). Since you ask for it, let me add it then.

I agree it's not a functional bug, but since the commit message
mentions "it has been wrong", I was assuming we might want to signal
when the inconsistency was introduced.  No strong opinion really.

Thanks, Roger.