[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [EXTERNAL] [XEN PATCH v1 2/2] docs/fusa: add generic timer arch spec with ASCII diagrams
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Weber (US), Matthew L" <matthew.l.weber3@xxxxxxxxxx>
- Date: Tue, 21 Jul 2026 13:52:12 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=boeing.com; dmarc=pass action=none header.from=boeing.com; dkim=pass header.d=boeing.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JUCHa3bKJEkKrvY4lEpVxWWAUoRn/VJ6Ad9ivBaWPFw=; b=V0BqJnXXkraSD+VZNk2wljWabbX94H6vPhyw5KVrwavi6mw1RN0bRtUrUVAUnczS5hRTMBZtNoFH0w/pUfO4sEvXzELzBNdZgNK8Pnl4PDmwn30ln+H1fSW06VEcdxTGiAKx39wgSJpbQaE4PfVQ8+Md89M/uvbHomtkUBQvKUhlySDDP4ki3vIwZTJtPODEaIzIFnmriTPZvvaAqlHHoV5mUFq3/Jf09QabwARjPAPyOV4DKUqIV0uLd1WdRIcXYzmZtV7sIVvL6Jjy0kHCYevlACs/5QsT0briTjFBl9dveYduah0WcV3alvRkLYf8T5VxkwQ9duBgupcYknpFVw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=QyWcSYg8d5fehExrsqEfo6WcsOgSnGSSGCiRSfZq0f5iZ11vD1plJSd20KMGKQCtWdrCzeMkK3B9E2SU8zzDrqxHl9b0gkxbBe607+9rK8owRToXrjwbBXY+SMWYxnn+/EyyZIHoZyczqv/djOhHymVTCW0Bauy4s8MCLdy2kDVONsi3q2ZsH9P74R2hp3bqj9TDpzmSlM1iILjJ6XHX4wVq/ihGHAuAHaFq1eUk01ORKQGKmyw+oy529JJp6fz7g9MGEs/3htcyVk++EA3Hvhs9VAGOKVKgFsWhOXITuU3odEaP9N+YZJn4ol60ewg+W0Dugwa2ib7fMRyQgz3NVg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=boeing-s1912 header.d=boeing.com header.i="@boeing.com" header.h="From:To:Subject:Date:References:In-Reply-To"; dkim=pass header.s=selector1-boeing-onmicrosoft-com header.d=boeing.onmicrosoft.com header.i="@boeing.onmicrosoft.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=boeing.com;
- Delivery-date: Tue, 21 Jul 2026 13:53:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHdGQ87b/N5pVUPx0Wqd9VFa4WMhbZ3/T2g
- Thread-topic: [EXTERNAL] [XEN PATCH v1 2/2] docs/fusa: add generic timer arch spec with ASCII diagrams
All,
> On 21.07.2026 14:47, Ayan Kumar Halder wrote:
> +Generic timer usage during VM creeation
> +---------------------------------------
Typo: "creeation" -> "creation"
> +- CNTVCT_EL0 - virtual count value
> +- CNTV_CTL_EL0 - control register
> +- CNTV_CVAL_EL0 - compare value register
> +- CNTV_TVAL_EL0 - compare value register
CNTV_TVAL_EL0 should be "timer value register", not "compare value
register". CVAL is the comparator, TVAL is the countdown/timer-value
alias. (Same naming as CNTP_TVAL_EL0 earlier in the same section.)
> +The interrupt behave in a level-sensitive manner, meaning the timer will
Grammar: "The interrupt behaves" (singular).
> + * - physical non secure timer
> + - 30
Nit: ARM uses "Non-secure" (hyphenated, capitalized). Suggest
"physical Non-secure timer" for consistency with the spec terminology.
> +| [1] Arm Architecture Reference Manual for A-profile architecture, Chapter
> 11
> +| [2]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml
These would render better as proper RST footnotes:
.. [1] Arm Architecture Reference Manual for A-profile architecture, Chapter
11
.. [2] https://git.kernel.org/...
That way Sphinx cross-references and numbered citations work correctly
in the built HTML.
Overall the spec is well structured, thanks Ayan!
Reviewed-by: Weber (US), Matthew L <matthew.l.weber3@xxxxxxxxxx>
|
