[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v1 1/2] docs/fusa: add coverage_gap.rst tabulating vGICv3 LCOV exclusions


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
  • From: "Halder, Ayan Kumar" <ayankuma@xxxxxxx>
  • Date: Tue, 21 Jul 2026 14:10:48 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZppEHMLD2CgtVy5TMRbwaYUtF0MWVB25EPVSEqiIHO0=; b=weSGsK19E/4qG2JzbVEkf67tdILT+3isPR4nditdrUHGQZGbxUeZ3PVegU/9Mu9VQXm2vkWbiWV4cz2/e4PK1FT3g9d4aq+9tsVfzA5mAkjX/u006+mdTkrAJ/Ro4GvUCh3prM1j3ZHhLXHkZJ5P/C/8p6C7+oamLu55NPVWMpZuft1r4u+0GpjRp34dHTsR/bTZzHzS0/3H8OVxO/1uo0/SZa5EmJzHXbvGaTcSthflESNMmVZGz0Quk30lK8AUfNbpwx+X0RbfjSRYQ+UJN2J/yDVVcbCcLxO2b98gRjZ0zZEWoJ2Zh6kpZfm4K58rW+egERulSc6Sbyw/e32Zfw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BOm4ppStJGQm5Ye7HnZcaDNJilrNVOKfwEEEw4wbmVlwSYFaBqHBZIsz1kahRHAW/LwkeG1BiWXMoVOFa6nTFQzwHKE8F/by6ECDhn1YSp+sTIa9no2Aa2FPpVJWzCzF/dLcWLgzYAycQ1svtblJsi0ms4/4H3oiLS1pnK9MxXBuJCxnzt/H+eFBpDOxktOW1uZ8LSPkXfsakwDuEoV25ZVXazXgRh6yX7wNoZgsj7jL5IVkhF8UQW+DURWp82YLn5N2RjRB1S7jDm1oSlr0AHKohuWMBJPG/8YDCwskvpeAtnlFpxClxhfStBoVLU2eISAvLGnaGOpF5lEDb4FCFQ==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <artem_mygaiev@xxxxxxxx>, <matthew.l.weber3@xxxxxxxxxx>, <harunobu.kurokawa.dn@xxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 21 Jul 2026 13:11:07 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Jan,

On 21/07/2026 14:00, Jan Beulich wrote:
On 21.07.2026 14:47, Ayan Kumar Halder wrote:
--- /dev/null
+++ b/docs/fusa/coverage_gap.rst
@@ -0,0 +1,41 @@
+.. SPDX-License-Identifier: CC-BY-4.0
+
+Coverage gaps
+=============
+
+This table documents the ``LCOV_EXCL`` regions in the Xen source. Each excluded
+region is tagged in the source with a ``COV-GAP-<COMPONENT>-NNN`` marker that
+matches an entry below. A region is excluded from the coverage report only when
+it is unreachable by design, so it can never be reported as covered.
+
+.. list-table::
+   :header-rows: 1
+   :widths: 15 25 10 12 38
+
+   * - coverage_gap_id
+     - file
+     - line numbers
+     - SHA
What specific algorithm? Or wait, this isn't a hash of the file, but a commit
hash. This imo wants clarifying.
It is a commit hash.

+     - justification
+   * - COV-GAP-VGICV3-001
+     - xen/arch/arm/vgic-v3.c
+     - L796-L800
+     - 351d41e8aecc3f7566a0baa7b4066d06dedd7113
+     - Both callers select the register offset with their own ``switch`` and
+       forward only offsets the handler has an explicit ``case`` for, so no
+       forwarded offset can fall through to ``default:``. (The SGI_base-frame
+       ``GICR_*`` offsets one caller forwards are numerically equal to the
+       ``GICD_*`` offsets the handler cases on.) The ``default:`` is kept as
+       defensive programming; it becomes reachable only if a caller is
+       modified to forward an offset the handler has no ``case`` for, at
+       which point this exclusion must be removed.
All of this is liable to go stale. Once it has gone stale, this information
is pretty much useless aiui. And it may well be worse than that, if the
"must be removed" isn't actually followed (perhaps simply because there's
no link from the source to here). How's all of this going to be helpful
longer term?

Using SPDX SBOM, you can link a document to a piece of code to a commit SHA. This was something that linux kernel has recently developed and upstreamed.

https://docs.kernel.org/tools/sbom/sbom.html . Zephyr project has developed this as well.

harunobu.kurokawa.dn@xxxxxxxxxxx is investigating this for Xen.

- Ayan


Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.