[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH v6 5/5] xen/acpi: Parse PPTT to initialize CPU topology


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Hirokazu Takahashi <taka@xxxxxxxxxxxxx>
  • Date: Tue, 14 Jul 2026 21:30:30 +0000
  • Accept-language: ja-JP, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kOJvXg7cAAxmAm/Wbhg/4vVy+dTO6gUZT+sQlS+81Bc=; b=xhPIw3cwNsUdu6qRpB9ytcaZ54J94zahpA34D03Mhx4aw7CkDkMFcw3MzFuP88MxkZy9D2g9sdAI2w/F06rpHC+b0Z49Q0Wz9oiJIr9OiZP3aiBkNF8guAGDKhCvQqWfj5xoHIAgfvBLUwBPaU1XDwcocYVEWxs0WxNkiqe/YzOF1OJ12VRcEeieVOAmFH60QiLOiINI/v63ss1OXkplGPa8VSHHbR7saBZ2gCCduxOt05j/uaqV+nVktTvA8wsRLrqjEtAyj9Yrfaf9i4LHTaA6RtDj7hcqNomOh6T+QTP4u1LcTkULSau81pbF6qVjME3MCExFl4BdTryw7jnAZA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=B33iiX22fokPxM3CSagnFFDHU6PTWLYxNiDX/bseuVCJqvHczpUEVpac3O3uYwiCseNV///AEnqkkgBotFqDLgSWVIVMVSDwRHm2oz3+Y58rw1mL54OU1TP1FIf1/DwUFEy3D91w5TEC+tVIp3JNMLKIX/FFZ+pc4HaHYUJtcejD+e3OSNxF5T1Z7Vjg0ShygMXbS03fveKIRaDNbp8j2gxQdMnywCGKEpBPzSjNql/Bat7rD+7P7fWcTjGlspjG5luVDWC41uqFdBzDtcZn1FsA6E+dlSeztj6sPRu4wxFFA8BdOUBwb2wDNTbRm049Z0gxmdZHdbSb3WVKYAxOlg==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp;
  • Cc: "Mykyta_Poturai@xxxxxxxx" <Mykyta_Poturai@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 14 Jul 2026 21:30:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHdE336EabuJxSEHUSo4bExE1f467ZthrLggAAB8dA=
  • Thread-topic: [PATCH v6 5/5] xen/acpi: Parse PPTT to initialize CPU topology

Hello

> > diff --git a/xen/drivers/acpi/topology.c b/xen/drivers/acpi/topology.c
> > index 56fcfa4945..e6dea527a6 100644
> > --- a/xen/drivers/acpi/topology.c
> > +++ b/xen/drivers/acpi/topology.c
> 
> 
> >  int __init acpi_init_cpu_topology(void)
> >  {
> > +    acpi_status status;
> > +    struct acpi_table_header *table_header;
> > +    const struct acpi_table_pptt *pptt;
> > +    unsigned int num_sockets = 0;
> > +    unsigned int num_clusters = 0;
> > +    unsigned int num_cores = 0;
> > +    unsigned int *socket_map = xmalloc_array(unsigned int, nr_cpu_ids);
> > +    unsigned int *cluster_map = xmalloc_array(unsigned int, nr_cpu_ids);
> > +    unsigned int *core_map = xmalloc_array(unsigned int, nr_cpu_ids);
> 
> These have to be xzmalloc_array().

xzalloc_array()

> I will fix it in v7.
 
Thank you,
Hirokazu Takahashi.




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.