[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH v6 5/5] xen/acpi: Parse PPTT to initialize CPU topology


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Hirokazu Takahashi <taka@xxxxxxxxxxxxx>
  • Date: Tue, 14 Jul 2026 21:25:46 +0000
  • Accept-language: ja-JP, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L0/u/pfinWTBoJJN7oUTBocdgcK7gmqRKa077vo9mjg=; b=b+DVtRrzQoTeDPAyZ2xA1ckcwfj7+aGhF+pvsGcfelB8gckW+/vvwxau7NUoEj+GGcPzXhDL/bjZc9NGPh+8qiLH+xSvDT/9qcR5W3NmM0mjElbIgSzW4uFCjQHBAYcj3DLlwENdxerG8EaEvTDIaUf0p1wONriGY+UL2ZVkq1y/KHf8djRwWXeeI7JbjapEbKKVlGKKM9PJgIovju63mBcQp6ro6Gx37QuKxM2T32F6oHGG91NOesCRRpd15UCmm4AJ69whuztECPA1BbLUPjPKhAgS7yciYuPHrTAeWZAYbc9yMi61stBsdHOYa3hEWvyeDmdtDQqxSUaArbr3qQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZzU9oSXCPAJ6sMxNuy5pf/Mt9jnWaPir9NqHrdKzy4OI2ZqfriiyO1qoOoMzOrJaIfDx7EGvSj3cJPezGR6fNUerL8cpZg2a/LKqaa8uf1AtARRtFh3i+XWWpTje7zrLRNmItUDBTKnbRIEqn2DolhhkWhK4NmQHmN3gVJkpwQHhAxT9rOrGCqBl0IDyhcnJ0vfithtGwVwknx4BjKy+MuZXAdQ1BY4VoqJx42Pdo78JxOx5qHC27mUDT5WLJwNIb5ISencJz/jDncs51XbfSuUs7ZO0Hp+bzDtY6/QkJudNmciDS48O3kJKm1bir0cdNvxyoYfGvIXXb3GRLAAMuA==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp;
  • Cc: "Mykyta_Poturai@xxxxxxxx" <Mykyta_Poturai@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 14 Jul 2026 21:26:11 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHdE336EabuJxSEHUSo4bExE1f467ZthrLg
  • Thread-topic: [PATCH v6 5/5] xen/acpi: Parse PPTT to initialize CPU topology

Hello,

> diff --git a/xen/drivers/acpi/topology.c b/xen/drivers/acpi/topology.c
> index 56fcfa4945..e6dea527a6 100644
> --- a/xen/drivers/acpi/topology.c
> +++ b/xen/drivers/acpi/topology.c


>  int __init acpi_init_cpu_topology(void)
>  {
> +    acpi_status status;
> +    struct acpi_table_header *table_header;
> +    const struct acpi_table_pptt *pptt;
> +    unsigned int num_sockets = 0;
> +    unsigned int num_clusters = 0;
> +    unsigned int num_cores = 0;
> +    unsigned int *socket_map = xmalloc_array(unsigned int, nr_cpu_ids);
> +    unsigned int *cluster_map = xmalloc_array(unsigned int, nr_cpu_ids);
> +    unsigned int *core_map = xmalloc_array(unsigned int, nr_cpu_ids);

These have to be xzmalloc_array().
I will fix it in v7.

Thank you,
Hirokazu Takahashi.




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.