|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [PATCH for-4.22? 3/9] domctl: rename a label
There's no real domain unlocking here, it's merely RCU which is being
"unlocked".
Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -373,7 +373,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe
copyback = true;
}
- goto domctl_out_unlock_domonly;
+ goto domctl_out_unlock_rcuonly;
case XEN_DOMCTL_get_domain_state:
ret = xsm_get_domain_state(XSM_XS_PRIV, d);
@@ -381,7 +381,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe
ret = get_domain_state(&op->u.get_domain_state, d, &op->domain);
if ( !ret )
copyback = true;
- goto domctl_out_unlock_domonly;
+ goto domctl_out_unlock_rcuonly;
case XEN_DOMCTL_iomem_permission:
{
@@ -391,11 +391,11 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe
ret = -EINVAL;
if ( (mfn + nr_mfns - 1) < mfn ) /* Wrap? */
- goto domctl_out_unlock_domonly;
+ goto domctl_out_unlock_rcuonly;
ret = xsm_iomem_permission(XSM_PRIV, d, mfn, mfn + nr_mfns - 1, allow);
if ( ret )
- goto domctl_out_unlock_domonly;
+ goto domctl_out_unlock_rcuonly;
iocaps_double_lock(d, true);
@@ -408,7 +408,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe
ret = iomem_deny_access(d, mfn, mfn + nr_mfns - 1);
iocaps_double_unlock(d, true);
- goto domctl_out_unlock_domonly;
+ goto domctl_out_unlock_rcuonly;
}
case XEN_DOMCTL_memory_mapping:
@@ -423,17 +423,17 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe
if ( mfn_end < mfn || /* Wrap? */
((mfn | mfn_end) >> (paddr_bits - PAGE_SHIFT)) ||
(gfn + nr_mfns - 1) < gfn ) /* Wrap? */
- goto domctl_out_unlock_domonly;
+ goto domctl_out_unlock_rcuonly;
ret = xsm_iomem_mapping(XSM_DM_PRIV, d, mfn, mfn_end, add);
if ( ret || !paging_mode_translate(d) )
- goto domctl_out_unlock_domonly;
+ goto domctl_out_unlock_rcuonly;
#ifndef CONFIG_X86 /* XXX ARM!? */
ret = -E2BIG;
/* Must break hypercall up as this could take a while. */
if ( nr_mfns > 64 )
- goto domctl_out_unlock_domonly;
+ goto domctl_out_unlock_rcuonly;
#endif
iocaps_double_lock(d, false);
@@ -468,7 +468,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe
}
iocaps_double_unlock(d, false);
- goto domctl_out_unlock_domonly;
+ goto domctl_out_unlock_rcuonly;
}
case XEN_DOMCTL_set_target:
@@ -477,7 +477,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe
ret = -ESRCH;
if ( !e )
- goto domctl_out_unlock_domonly;
+ goto domctl_out_unlock_rcuonly;
if ( d == e )
ret = -EINVAL;
@@ -492,7 +492,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe
if ( ret )
put_domain(e);
- goto domctl_out_unlock_domonly;
+ goto domctl_out_unlock_rcuonly;
}
case XEN_DOMCTL_vm_event_op:
@@ -502,12 +502,12 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe
ret = vm_event_domctl(d, &op->u.vm_event_op);
if ( !ret )
copyback = true;
- goto domctl_out_unlock_domonly;
+ goto domctl_out_unlock_rcuonly;
}
if ( !d )
{
ret = -ESRCH;
- goto domctl_out_unlock_domonly;
+ goto domctl_out_unlock_rcuonly;
}
/* Other sub-ops handled further down. */
break;
@@ -517,17 +517,15 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe
op->u.shadow_op.op == XEN_DOMCTL_SHADOW_OP_PEEK )
{
ret = xsm_domctl(XSM_OTHER, d, op);
- if ( ret )
- goto domctl_out_unlock_domonly;
-
- ret = arch_do_domctl(op, d, u_domctl);
- goto domctl_out_unlock_domonly;
+ if ( !ret )
+ ret = arch_do_domctl(op, d, u_domctl);
+ goto domctl_out_unlock_rcuonly;
}
break;
case XEN_DOMCTL_get_device_group:
ret = iommu_do_domctl(op, d, u_domctl);
- goto domctl_out_unlock_domonly;
+ goto domctl_out_unlock_rcuonly;
case XEN_DOMCTL_ioport_permission:
case XEN_DOMCTL_ioport_mapping:
@@ -537,7 +535,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe
case XEN_DOMCTL_unbind_pt_irq:
case XEN_DOMCTL_getpageframeinfo3:
ret = arch_do_domctl(op, d, u_domctl);
- goto domctl_out_unlock_domonly;
+ goto domctl_out_unlock_rcuonly;
default:
/* Everything else handled further down. */
@@ -546,7 +544,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe
ret = xsm_domctl(XSM_OTHER, d, op);
if ( ret )
- goto domctl_out_unlock_domonly;
+ goto domctl_out_unlock_rcuonly;
if ( !domctl_lock_acquire() )
{
@@ -941,7 +939,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe
domctl_lock_release();
- domctl_out_unlock_domonly:
+ domctl_out_unlock_rcuonly:
if ( d && !is_system_domain(d) )
rcu_unlock_domain(d);
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |