[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: gic-v3: Fix redistributor wakeup polling
- To: Luca Fancellu <luca.fancellu@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Thu, 21 May 2026 09:06:59 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r5mGbkkwVs8s/HN7qOdJ3f2S3rRuN4gFpBiFq5edXAY=; b=S+jHg9qA0Xy9eIsiSrOOb9bsgw8AQjO/bBamRWKda0NoO3Iullu4BNc3Xl+IQ9yNBc4ulj3Cv3IpcXbXQHlS80qIuzTB1dhL+g3FJAT27q4Bxpq2cuHTaKX+dnQcqa93jKhr614aQ3PzGOReFf/udc+y6PWxcsJ+njz3mG5ZZfWxZgM8Reb0xTJ0KvH9R8KJIWXA+3E36xMrAKGByAURwH6YfsZW2e3YiTTyFSRA86zhx/V0GWP1cv8/jjZ3K5JZE2Bm1fos3qv26KfmE6oLbnkHIiMmqDJeNvx2JIGa3UofcKCcdpcgOw44ZZ2DajpmtNaVucbcdHiw5vIY2wiwNg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XUKrdQjw/Al4dhb44yNpSOalj949dxfYLuR778quSdznIPEIldg3xcFDe4kqZBsy07IRtJr6ucF6QGor5TvOkG80c+FH7B4PrrKx0TwjeGv8pVqGJN2dOhvxXJoBoJbAhWH8GZ5XfHFpDrkhLLrMZksMHJgdEQq1XHmqzTy002c/o9rGBdKbgjJhUuYpSH47Lu2xZUfU4ChfyS8r8PGR5jXRfqZmbobgFBTrzK8FbgDGpjrgy0/eyV+MJWiKjdhXF5ketl9luBhrvR6+cizEg5S4PidkDUl2mCfnPD0Z5yC6F1udlSFlx36AasC2SzE9XPdaYjMqyGv/V9icQXPqJA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Thu, 21 May 2026 07:07:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Oleksii, can we ask for a release ack for this fix?
~Michal
On 19-May-26 09:19, Orzel, Michal wrote:
>
>
> On 18-May-26 09:05, Luca Fancellu wrote:
>> gicv3_enable_redist() clears GICR_WAKER.ProcessorSleep and then waits for
>> GICR_WAKER.ChildrenAsleep to clear, as required after waking a
>> redistributor.
>>
>> However, the polling loop currently uses "while ( timeout )". Since
>> timeout is initially false, the loop runs only once unless the timeout
>> path has already been reached. As a result, Xen can continue before the
>> redistributor has completed wakeup.
>>
>> Use an unconditional loop, matching the surrounding timeout/break pattern,
>> so the code polls until either ChildrenAsleep is clear or the deadline is
>> reached.
>>
>> While there, also fix the timeout message. This path polls
>> GICR_WAKER.ChildrenAsleep, not an RWP bit, so "RWP timeout" is misleading.
>>
>> Fixes: bc183a0235e0 ("xen/arm: Add support for GIC v3")
>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> ~Michal
>
>
|
