[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: gic-v3: Fix redistributor wakeup polling
- To: Luca Fancellu <luca.fancellu@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Tue, 19 May 2026 09:19:59 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z16yhBir+oCgVOrPPXL53jORhztnzJIqAkRmY0B6nyA=; b=asv7GoP4bGbDbacKkYJF2Aj4IjniioqEOptxhkbfXfeGFLqoyEt+YMLoyV/eyTuXuxSw9GgKhDRDECPrnj3e6QmijyCX2fxyqLrrFOlXsUBYKGDVd/+mVL/MZb4BGA1dGHLcbvYmmX4NIEB3/Vybk3mfiVRo+5Ziw8Y0fe/rTFPLO8K4xJyT8SvANXQXbuu4sKQxE8IuFS/sTBjFH2mr2gnjVxxbHDu7HiaPZ2iSPfstjSz3D9VUhIgUK4CfykDZGw/3LGzGIretNup6KEfnITxFFr9c9zwOOY3cECGF9yh63tZhP8OcLa5xkjBEy8mU14g8oABaZaKyaK5EYCuXtQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=INPl+KLtWhyVoK4b0YOjtJ8HG95Z5qRIiNt5OvTHDuENZlym2WbIRsXT2HNDi9JKXe1BI2nxFnZMGmT0UC0BrMjPmFyjLOTsLxoBQrhYx2jbmwWPvwfUXlFCotl8rIDEiZzgcJ4EFfIZ8PNLNwqYTkaPy5sDdF96Z+xWZfU9KIY1DT/qE04mxkCpM8ikw/jKuY5UyYYY7s6KSBouT6A/XJMVcx/LGDQ4/n3Y5AtQRBaQWowonXRsGlSLu+xEjeqcYJDiyxTnIx8vX10FQGYubnMbb71Vi1SNG8x72IvuxytoMa4fnTecSSboW3GwaNb0z87wjUrFnN2iQMOFSXfrkw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 19 May 2026 07:20:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18-May-26 09:05, Luca Fancellu wrote:
> gicv3_enable_redist() clears GICR_WAKER.ProcessorSleep and then waits for
> GICR_WAKER.ChildrenAsleep to clear, as required after waking a
> redistributor.
>
> However, the polling loop currently uses "while ( timeout )". Since
> timeout is initially false, the loop runs only once unless the timeout
> path has already been reached. As a result, Xen can continue before the
> redistributor has completed wakeup.
>
> Use an unconditional loop, matching the surrounding timeout/break pattern,
> so the code polls until either ChildrenAsleep is clear or the deadline is
> reached.
>
> While there, also fix the timeout message. This path polls
> GICR_WAKER.ChildrenAsleep, not an RWP bit, so "RWP timeout" is misleading.
>
> Fixes: bc183a0235e0 ("xen/arm: Add support for GIC v3")
> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
