Re: [PATCH v7] xen/domain: introduce DOMID_ANY

[dmukhin@xxxxxxxx]

On Wed, Apr 22, 2026 at 04:07:55PM +0200, Anthony PERARD wrote:
> On Wed, Apr 08, 2026 at 04:40:46PM -0700, dmukhin@xxxxxxxx wrote:
> > From: Denis Mukhin <dmukhin@xxxxxxxx> 
> > 
> > Add a new symbol DOMID_ANY to improve the readability of the code.
> > 
> > Update all relevant domid_alloc() call sites and harden the domid_alloc()
> > input value check.
> > 
> > Also, fix problem with passing invalid domain IDs in
> > XEN_DOMCTL_createdomain: turns out libxl__domain_make() (toolstack)
> > uses 0xffff as domain ID.
> > 
> > Amends: 2d5065060710 ("xen/domain: unify domain ID allocation")
> > Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
> > ---
> > Changes since v6:
> > - fixed libxl_domid_valid_guest() check in libxl_create.c
> > - Link to v6: 
> > https://lore.kernel.org/xen-devel/20260307025451.3148078-2-dmukhin@xxxxxxxx/
> > - CI: 
> > https://gitlab.com/xen-project/people/dmukhin/xen/-/pipelines/2438790748
> 
> Unfortunattly, this patch breaks tests in tools/tests, see
>     https://gitlab.com/xen-project/hardware/xen-staging/-/pipelines/2471684142
> 
> The tests produces this:
> 
>     Running /usr/lib/xen/tests/test-mem-claim
>     Memory claims tests
>     Free pages: 3059012, Oustanding claims: 0
>       Domain create failure: 17 - File exists
>     FAILED: /usr/lib/xen/tests/test-mem-claim
> 
>     Running /usr/lib/xen/tests/test-paging-mempool
>     Paging mempool tests
>       Domain create failure: 17 - File exists
>     FAILED: /usr/lib/xen/tests/test-paging-mempool
> 
>     Running /usr/lib/xen/tests/test-resource
>     XENMEM_acquire_resource tests
>     Test x86 PV
>       Domain create failure: 17 - File exists
>     Test x86 PVH
>       Domain create failure: 17 - File exists
>     FAILED: /usr/lib/xen/tests/test-resource
> 
>     Running /usr/lib/xen/tests/test-tsx
>     TSX tests
>       Host: RTM 0, HLE 0, TSX_FORCE_ABORT 0, RTM_ALWAYS_ABORT 0, TSX_CTRL 0
>       Got 16 CPUs
>     Testing MSR_TSX_FORCE_ABORT consistency
>     Testing MSR_TSX_CTRL consistency
>     Testing MSR_MCU_OPT_CTRL consistency
>     Testing RTM behaviour
>       Got #UD
>     Testing PV default/max policies
>       Max: RTM 0, HLE 0, TSX_FORCE_ABORT 0, RTM_ALWAYS_ABORT 0, TSX_CTRL 0
>       Def: RTM 0, HLE 0, TSX_FORCE_ABORT 0, RTM_ALWAYS_ABORT 0, TSX_CTRL 0
>     Testing HVM default/max policies
>       Max: RTM 0, HLE 0, TSX_FORCE_ABORT 0, RTM_ALWAYS_ABORT 0, TSX_CTRL 0
>       Def: RTM 0, HLE 0, TSX_FORCE_ABORT 0, RTM_ALWAYS_ABORT 0, TSX_CTRL 0
>     Testing PV guest
>       Domain create failure: 17 - File exists
>     Testing HVM guest
>       Domain create failure: 17 - File exists
>     FAILED: /usr/lib/xen/tests/test-tsx

Yeah, I did not run those tests locally and the failing tests are not part
of "basic" CI, certain gitlab privileges are required to execute the full
CI test suite (as it turns out).

Perhaps tools tests should be part of a CI runs available to all users,
at least on demand?

Sent v8 with a fixups for the tests:
  https://lore.kernel.org/xen-devel/20260507202840.293269-1-dmukhin@xxxxxxxx/

(Thanks to Stefano with help on running a full CI cycle).

> 
> At least, the domid test passes :-)
>     Running /usr/lib/xen/tests/test-domid
>     PASSED

:-)

> 
> 
> --
>  | Vates
> 
> XCP-ng & Xen Orchestra - Vates solutions
> 
> web: https://vates.tech