[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 06/13] xen/arm: tee: keep init_tee_secondary() for hotplug and resume
- To: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 27 Apr 2026 08:19:11 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=gmail.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vFXEgwJbXYOgjdf8Mo6Sab4nd2d9bIKymYBPd6sxkRQ=; b=pbSjodl+SQeuY/bymobrKVpxMI0Imy41oJh7YtEPsXC3Ztx/aXPm55OrsPzU9Qox83st67yT6jnPuvEOv1Bj+f3hMW1eaxMvHSAjrfKTJXMiLMyzDthCLOCiH7QUxoo1XsMHNCvjsfaIR2gHEcrlkcvkCAKCoZ0rc+7t3leOvOGsEXJ7dPZS2YjwGKZ0rlhYewT1WepVPzA49WixjEBKBXT7dv7/5zruHEvzwt4qhscArtUubgkHmzi/2uEd+EHyJcBIy7VsvHjFBBzZHF2TdfzBAl6U5W32Xk1HkyPE/xwVtN7nV6eAtDNVuyDV+lZIsFpV/whQiBffvY5znA5ZIA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vFXEgwJbXYOgjdf8Mo6Sab4nd2d9bIKymYBPd6sxkRQ=; b=QDmNQWblquYbOu/V4xpvPhmbXiwQW9w+6IcLBFN4GrAIAsaL7z0fimhio+jfcEEOcqdOflGCipawfCifEJ/LOF15LP9taijNAjXMo1AwzjBhg9hQ6cnixUhV7PD/xqdv1wIR9+KWV8Q+LSLgfVdtnCsSj6DTL6yAUvo3cXFLILdAAgpHF2Svg6OE9a6caxghm6qlRtylOHI889kuVoJdcmZ76iDYKPyDxqyI/VN0489YD+S0Y5jPS+Ej9R7W3SwS1fN8Ln4ahNxIf80O9TfRieQtYgINhS90k+ifXiiDdFBRCRFWZfz6CMU48oQ12uHQ7sPDWTLQKHJdfVL65MRBlg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=ET8rgDXXvf0/qN4Gc+VN3bwtwHxqBwM+p8IF6RWVH1m7nvYKBrCdSvkCbAiEg3JWiew5AuJdyyKB5sZPxAbtZsFOFXwgYD8tIeExBoc8nZZe0Nhb4Sv2pFa5WZHTlF+pfr0WKeQTj0KoAYo0KgtjKwPMo6vP5hMgioMHj6IxfqoW/BGGl4rUhO7M9Ny1DY38g/cGAxittqVezSFu+c8zU3pExWvBt8DYwY1DgGK5rZcwFlM0wkPIOOI8yF5Gt5D47QCSewNHjBvRgvI5z3T9axBIaJN+Acvfbp8ijBzkQpZuiVgZsbrbWfmin8/gZtC6poAmHdsSp7i4OWK1US/I7Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lj3BKDmX/GxDuGRtSnAzZ6GiRQxRjN2AGHYGqpvRGXplOA0K89V9DSK4mK2cZ8b3OIlZpeyiCCShgGmkfbe9nIgamq7XOkvlnwUE0O7TTxmzPqywlCYHxAXixbi4QjWB+aLOaw9ihT5QDY40t2brcvKLv2pPyLWzV+8BqRjN9jGZFLntTdVISgO9nBrqtOnypOwmP6AqxL47oCJByVCxDvLLyAW21gTgi1WuP9PTMr4Toz2xAigEn5bMh64mur709bMg4HPnQJg4i6BMO+63Wipj0uibB++Nwct9jIqcjn+vBEFuhNDDKyYEcIUxAKb/PFeqFAzCaBxq7nDpS6DzJQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Mykola Kvach <mykola_kvach@xxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Jens Wiklander <jens.wiklander@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Mon, 27 Apr 2026 08:20:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcwo4fuKBruO1pu0mbPZdZpnwt6LXyt+WA
- Thread-topic: [PATCH v8 06/13] xen/arm: tee: keep init_tee_secondary() for hotplug and resume
Hi Mykola,
> On 2 Apr 2026, at 12:45, Mykola Kvach <xakep.amatop@xxxxxxxxx> wrote:
>
> From: Mykola Kvach <mykola_kvach@xxxxxxxx>
>
> init_tee_secondary() was marked __init and freed after boot. Calling it
> from the CPU hotplug/resume path then executed discarded code, which
> could crash Xen. Drop __init so the TEE mediator secondary init can run
> safely on hotplugged and resumed CPUs.
>
> Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/tee/tee.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/tee/tee.c b/xen/arch/arm/tee/tee.c
> index 8501443c8e..00e561fc78 100644
> --- a/xen/arch/arm/tee/tee.c
> +++ b/xen/arch/arm/tee/tee.c
> @@ -128,7 +128,7 @@ static int __init tee_init(void)
>
> presmp_initcall(tee_init);
>
> -void __init init_tee_secondary(void)
> +void init_tee_secondary(void)
> {
> if ( cur_mediator && cur_mediator->ops->init_secondary )
> cur_mediator->ops->init_secondary();
> --
> 2.43.0
>
|
