[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 06/13] xen/arm: tee: keep init_tee_secondary() for hotplug and resume
- To: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 24 Apr 2026 10:59:59 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=gmail.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pClc1SyCOQKZ1GGjSYisodXle1Fg+GHUdenSnzYGUss=; b=lkLDRMXqAF9ABfDO+AZ3Bt00IxQ6gbSM/amIwheyluWZ6ythcwbnVnslTfBGk7o64HDuTkSr+VwBeDw7g3e4AuDZZm65dTBQ+IDCfoXwYZuz4uYYrsQkxca6lhdmOEQwzNSmRkw4hd8t7S7MrGayX7VfLmLZEMv2aHzDNEqcN62UfwM8m21BHqPP+aVaFHyRioZPGG74YUOppNxheRvAr0RaZSqAU0gkKhG4Ru0CNaq8Jgoitj/AsGMYjHK6iaqe8+lTQ5AVG04qxXWaTBB0UY6bH/c8YRaWy2V/dyEY7J64lR+6b/QiwIrlXgObUTLAcXenZKwjPl5/FzcyVhHP4w==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pClc1SyCOQKZ1GGjSYisodXle1Fg+GHUdenSnzYGUss=; b=H+sJFsYDHr3fPwohVjVGqCD9rOcJszJ682KQPlkSomfhCQUUZ6ioiD/sDGWNZAPjKTXfQ9+0YNIXPfbOb/V9SEuXsZGuPhvunotxjEw+D46yJQiGEfWV9/M8/tKHNJGVP68W3jv68mGJ0e+j+VNryInjCcxtphVpzS7kNZT97uREPfgTlByfC2R8ZP6ChYJ0hdJW1NRxNiZ7YWncjgAJj8Q5b5D0DSR4hPY4D5dVsBeDwVj1FXm3jI4D7mVDVKvIDWAALX7GChp3oAQ4Xfk33T+fj6wrHPa22d2tvALFkx9NIocSWBzv3MEzd6ErZML3pWZBhqV33zuEBcsgX7TLMQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=xq9ocaa82SyvCMr4a+tr+XQT/O/OJPtMoN/L8miAWsX91S4yQWnVZJzBS6h8HLJ8+svcqPCrbmKdYYUdd9dI2mtDxUAxKkKBjEN10GhKdwRML0hWZa0ZWIF+NYhhsiu+BFbj35aoHds6O2OhJNZWOLGZj9ahJKN2AneyJhBahoDBQ+aLyjndw4DxUEC9VJN9hLW2hKHKUvNAfDIPLAcJmo9SmviGkFRt//54+BtI8LAcQSbgKuhRv4+AF8/ap56GSLdH3LsyJYaljzM3CMLYA08Kqt36AuDZzr7cOegIkagX7CIduQYLZV140ieP223B9iIi+Y1X1zUUY5zK9TWCrQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Iv2ip3brgU1kGp3/YC/gXIueeVVfpQkOF3npztQWrWfXmXwatYJuyCFrhG2/lOhgtCltrjzmQX9REA4xl9Z0pv6MpqHLjhImYaGb3mUFwWCTd6M2PjypXCPjTAk4eTwSCy0baRWsR0WnyAW/LBAhUn5HuLWORUfluQUW6e9qwTKgI3kwie46ffXa9F/VOO+xkSI+bZr6Rk+tQZB9KmXt0LQ8KfrRIdMciZWDWZ+XtkiBfZ5DenM/K4HEn0fo1/q55zxknsk4zOwu0aa8Aff8uiFhmXJtgdhge18gWR9G2qOmh00QTvMscB5HYXZ1GxnvLLucLFCisBkOsPJt/eoa2A==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Mykola Kvach <mykola_kvach@xxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Jens Wiklander <jens.wiklander@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Fri, 24 Apr 2026 11:01:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHc09l+7v4jgDmb+0a+B+BWKNJH7g==
- Thread-topic: [PATCH v8 06/13] xen/arm: tee: keep init_tee_secondary() for hotplug and resume
Hi Mykola,
> On 2 Apr 2026, at 11:45, Mykola Kvach <xakep.amatop@xxxxxxxxx> wrote:
>
> From: Mykola Kvach <mykola_kvach@xxxxxxxx>
>
> init_tee_secondary() was marked __init and freed after boot. Calling it
> from the CPU hotplug/resume path then executed discarded code, which
> could crash Xen. Drop __init so the TEE mediator secondary init can run
> safely on hotplugged and resumed CPUs.
>
> Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
> ---
> xen/arch/arm/tee/tee.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/tee/tee.c b/xen/arch/arm/tee/tee.c
> index 8501443c8e..00e561fc78 100644
> --- a/xen/arch/arm/tee/tee.c
> +++ b/xen/arch/arm/tee/tee.c
> @@ -128,7 +128,7 @@ static int __init tee_init(void)
>
> presmp_initcall(tee_init);
>
> -void __init init_tee_secondary(void)
> +void init_tee_secondary(void)
> {
> if ( cur_mediator && cur_mediator->ops->init_secondary )
> cur_mediator->ops->init_secondary();
>
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
