[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/5] vPCI: move vpci_init_capabilities() to a separate file
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 20 Feb 2026 09:48:47 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bG3XSX3WWE4jgKeyckeb4tuY6g5uiS9krAoBVcGeek8=; b=ETXnIePfJxekMOWi5MR2ABa+vPsLDnENGHPYMQLk9POpLflv4TbkZpy5JBtccFNiI89UV8osoJCOOPkNt8fU4LXI/GaYirC8Mhyt3F+UhVltZLBrMAIJNhZaaTBsLwzr1bOR+5tHRGko3KNoE4lCLr6jol0alXXF7B+vLtR4IViF++beKFp6bpBrmXAc00PE5HKek8SsrZQTHpwCwz21C6DxQmNpYQGQyz0tk6EaibNJAG/peSPC4PX6SdHa2/cvHSwh/RQ9swLx/7dIyT8cjXKn9gtw/55dJoZ3TdPJQFvNcu6r2SXdid87wCbsjUEF/wQyNaBmvtyyLZlK2BrXZg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NL2NBGw1Mfuak6N9moH3Dn3z2f9CgypPXa0Z/ovt/8st3JKQQ8y2q3lN0D3uWNFKNP27RA8/B9/Yi3+wsmIRzHzZ+rCYGmbXmLC2OVfsVQ0KL7iK3Q8Js8GS6vo3pbE/kAsphJI//AedAKl0SLAfXf+jUy0ds7jGVjfydouhAiW1U1oQd/rirTdWytv5TI5vn8O/qSnEswcUb5vsAuvvVnPPpcxOMsplfX8Md1MU04p5HqKyBDjrmR9YqV2PyVEkI/2Voessgy3opfIvvpwLxRlC5oBMyeZBAOzmChhZkpl1bEDZpTI6316Dw98wRPviTPl1I8Eq4oM7VtNuRw7S6g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Delivery-date: Fri, 20 Feb 2026 08:49:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Feb 10, 2026 at 11:54:18AM +0100, Jan Beulich wrote:
> Let's keep capability handling together. Start with moving
> vpci_init_capabilities() and its helpers, plus splitting out of its
> cleanup counterpart.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> vpci_get_register(), while now only used by cap.c, didn't look like it
> would want moving there.
I think it's best to keep the vpci_{get,add,remove}_register{,s}()
functions in the same file.
Thanks, Roger.
|