[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 3/5] vPCI: move vpci_init_capabilities() to a separate file


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
  • Date: Wed, 18 Feb 2026 10:50:01 -0500
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eiDC6gGtcvi+Z1M7pdgqZLR9NEQKhSwZ1067MLtFS5I=; b=esjr/cXrHZ79Q5Mw0Mo1ifEPcaocboeMO2nsh1kcfWVv4HM2/7kCi5nT8wMqDMe31MS0FQKUox2eDDZvB0L9nDQI8xNONXwtP2AZg/ukqQIDhhhGgaOOlyX9/Pp4OOirzyTVo5OQb4W4NsBYOeGXCDKIrajT0nsum9UEPM5RzpseaySpXiVe7eAwfcGjLjYWkgbqFa67ABuBPGK4fmTct3yWCszEZEBma3znJB0H0iSN95rHA01HdQtNaeSg2DSrHZIRS03uFsba9hYpDPrCFADisRBbF6yYWh0AxsshuO+srUMktTxZaa1TgltKlr9FKxnLEoDkaCyJlwc6Hq5tZQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HA4+Q9NHKYGncshG83j3/NYPK5U/UmUCnWXPTcCm52yhsED6cWyz7gJWYSl5GPc8SZXEX/CiWd73PhiEkKsaWiXqziryBoQV74+R2pnszRb9z+aR3I0A5KiQsYJo6oYOP3G52ImYIXPCFKSu4JT6xP4OMsFzAd7/ZYW/4fQIqMhaiu58MYu+xtCiZRFHE7DQUB5okm34XJ1/bWyXMmdmAclQh+PyRLCh5Nfqa58IBYBWH/C0P46H7YE/pzIb24LI6nbX+f5zdl6l+kWgcxEJKSlMbfBz+ccBBtz2ygtSYRDKPcSqsUf56zZp9jCS0QyZETf4I1Pyho3mjpmmpGQxuw==
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Wed, 18 Feb 2026 15:50:11 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2/10/26 05:54, Jan Beulich wrote:
> Let's keep capability handling together. Start with moving
> vpci_init_capabilities() and its helpers, plus splitting out of its
> cleanup counterpart.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>

> ---
> vpci_get_register(), while now only used by cap.c, didn't look like it
> would want moving there.

OK. It seems potential opportunities for compiler optimizations would be small
anyway, and this is not a hot path.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.