[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/hvm: short-circuit HVM shadow guest creation earlier
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
- Date: Mon, 9 Feb 2026 17:02:26 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ByCoykMzK4VS3lzYyWHsKf3tRgRTFBivPsHAMyIL+H4=; b=B3uL6KGwF7ej87FJG678k9Y5u1LzDTkP4tYfxtniUbOuoPKRS5tvzlHUlc20HtnDt4d/oF8Qb3N4eKNXiKV1Lf8pmhFwe1mxsLusEM2uWKMTvc5SDzCHo/J8hmZnS1GZiVXp3Yxu68Dp/o1LNaQ4SbPcecG4/L1Sfwd9Yct0auOIzi9Pv94E1uQhbuNdicMR5qgjothL0Hnut+Rt/wmutyXZmnmO6Qky3WZfqNgHoO6rh1PODMIvWwMSRZQCRvOms1NOqSyfynqXe308EWvuUIy1IV0VGiLjCo4Jt2FHbBScnQaYkcf4xzwurfHWFVv7eZ/ijC2gPLg5vyu7FneRaw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MbiUSahR/cbZt0iZKLITNpm/wqbGnBoV3wXyTthQ8uronsReoyXvLZnSSWv5F+nAgtsbOBwIC0GtsitBlZumq7CZXCIprukjHuJzif9qUbKqGY2I4WwYwvA1N5S048/486FMozijzjAzkwmyOkV05g9P+pQNaLCIENwoGD5d7esmR3txha84+q2yu/JSBa7ijcEOy75MD/+aUrHz4BgLmVuTt1BGk3jYzaIdUTLS5ZE5YiiuzW5Zo/666t/WE/UHMyFLvyOCkpWO/z7buJrRerhFrEScxNYZD3VI+aLJbOnydxiybxNHNtWW/IiwHqiCW1XWw9bMAzIiLGMzS0y92Q==
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 09 Feb 2026 16:02:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon Feb 9, 2026 at 3:40 PM CET, Roger Pau Monne wrote:
> If shadow paging has been compiled out short circuit the creation of HVM
> guests that attempt to use shadow paging at arch_sanitise_domain_config().
> There's no need to further build the domain when creation is doomed to fail
> later on.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> xen/arch/x86/domain.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
> index 8b2f33f1a06c..8eb1509782ef 100644
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -627,6 +627,12 @@ int arch_sanitise_domain_config(struct
> xen_domctl_createdomain *config)
> return -EINVAL;
> }
>
> + if ( hvm && !hap && !IS_ENABLED(CONFIG_SHADOW_PAGING) )
> + {
> + dprintk(XENLOG_INFO, "Shadow paging requested but not available\n");
nit: s/requested/required/, maybe?
Also, with this in place can't we get rid of the panic in create_dom0() that
checks an identical condition?
Cheers,
Alejandro
|
