[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] x86/hvm: short-circuit HVM shadow guest creation earlier
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Date: Mon, 9 Feb 2026 15:40:49 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5vnjWHHeT8/l+RzwQ5S+oy92xbLdGrhmy1Q8HLAPSz0=; b=rZPtZRoCWFr/GMJW3hYbPp0DdvofySgUMtHjuFm2jk7gRiQmZ+QvPK65tL/jWvs7peJeMUzv4cenVypueqkaRn1WH8esJEOOsxydEHa4VXpbltUPE+dus5+LJqa+rlBbkoPT/8j6Q1ntwilySYle31NQo8znGA4wd3tYzHxpnr4SY0LxaizrWsjVJZlTnTWqXxdi3dJYbDz/yRG3WM3NwvuaYrtTjIoS50rVxoeY3rFlNaXEmcz/HUakbPrpvRa+2xgqkhJEq6R8bP0KUa4MKgfCwnylvD8eyEYv0UzgSQxIG0RlPJ8TkKFR6GvZEt2mLtiFqW9t5lJe75gXDQicgg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Nnyf2ogBZH3Y7/qcnevx6p9v+z4gWTNF4cgQTfBDrGYB87j13PRXpHRmLrarpnZEvt13Ti/W0RvXkUlea3PYHk2kGJpuBOs10s7Y1Zcxr3LbraHUnA3eh4Yjmr01i+BieGzbpRgywcsv4ydkDikLaPwRcI73I82XEXUwFnVoGT7Wo9ya8CQWqDPXOQ7gdKNu5wl7BLSQZZX+DCv0nEuJpfWiIod5PeCJN5qxZz9h38z8Be9SAvBPQvTWby/jAfVnn1KC8ppPCBxNFZVredA/3WLXRlCeUHok6Z5oYVf0X/kyby/54e1MSdjbJEQPCZrVXolmIz/R8NVvjosdan4qfQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Mon, 09 Feb 2026 14:41:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
If shadow paging has been compiled out short circuit the creation of HVM
guests that attempt to use shadow paging at arch_sanitise_domain_config().
There's no need to further build the domain when creation is doomed to fail
later on.
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
xen/arch/x86/domain.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index 8b2f33f1a06c..8eb1509782ef 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -627,6 +627,12 @@ int arch_sanitise_domain_config(struct
xen_domctl_createdomain *config)
return -EINVAL;
}
+ if ( hvm && !hap && !IS_ENABLED(CONFIG_SHADOW_PAGING) )
+ {
+ dprintk(XENLOG_INFO, "Shadow paging requested but not available\n");
+ return -EINVAL;
+ }
+
if ( !hvm )
/*
* It is only meaningful for XEN_DOMCTL_CDF_oos_off to be clear
--
2.51.0
|
