[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] xen: Use MFLAGS for silent-mode detection
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 6 Feb 2026 07:53:04 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=suse.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LsIBgg5Jdm8OVT/O87Y/EymGpgNHjPl3oSkLoUgTdXc=; b=TjT/0d14QI4gR5qLA3cgiJp8HtnPomDzjYHLr41lGKGj9/b29Qy/g71Zh5y13Xuj895Vv+Nmd7uDNbIkxft4Yjy4QV/7twjldtYw1QotmW5JYlXNCjTyfT666J3wDk67CVKwf/ZH8huYU3NAfBnHVwJPXR1ZKuJ3JLG6irZTu0/mrv3JcIQw0GkrJdMt6xrfjF6Y5vVTFpVmERgnDZnKe7jvk22p9wXVhzFPpnMpKtvNSiUshZfb9AlX1oI/fFx3KyWJNA0CA1s0qHw/Z8IguHcVwXQoocbeHi4Vcmr/l7x1qfRgYhtmcsPfu4p+ngqWjnyqV4jM9jGm82FLuVFXwg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LsIBgg5Jdm8OVT/O87Y/EymGpgNHjPl3oSkLoUgTdXc=; b=YRZoYiNs8k71T+ob4uzONLVX7HEYbO4KxFiFRQqkyx+lFKinkWI16wyhdr20tb/nDtXxAbcDwXYUG+iMbED6JS//GSveufgo3kx0tb3ulNYk5SLUy9jueuG6WYDq4KH3wkd/ojONFZdcwLmxluuEQBG0TCArJVusw4OdEU3rGOOwNplHe45RFq4gBZ94mZixioxw4A6Ps7wN8WGoLVF0/u6Wtui46XIALzuoEzkZrc8C0bm1jbmJYU2lK8EnT8QrDHQKIHS5kmDOmYrQp4DAMm/QzGO/SEg3ZCvX+u+XwcTkH4CojCgaOJbBBhZtPqHyaGraXWlfoGiwLlWf8QlVSQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=EJS7Ql0VXj7pFMWH1dParq+q1f81C6bEu2Vdfi0/zCO4x3a57mTMAA9YvHN0UdKW4l0Hs4f8pBwyyo1mXRpY31Bvw0vtBvtyoVvlIQrVQDNjw/FdLIX7igl5ZjN8Yl/AgMNZYdrU4xMQoENcRC54jVQhl391XqDEgifF6OKjMEM8PLVhpOVZVYItG688bOyzzbckd/iF9N0QyoIBIdTdW2u2gJHhMAnP03VYhM/L8g6rVnrRykUg3J+z+u/Uw9zd+Vkrh5RWt9vsWrMlvV1hWL4n8dvVEX2ek8qOlzvV8+c8uK4dJSmXLK3l091mu6Wfm5LFfp2f+ShcfLtXHbvLtw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uLhBUNsrPCHdLtb4OGp67UAQEEIDY7RkGINTQ4Q7q9hl2hWUS4a5uYWJRnTjqh/3dw9jeLS7fBGvbZ0pv51vIzx3lyXTlQccn4Skn8N6LA6WTd92W4T7Gcehf86XGOyTXBf+l/EhjYC64PqU8vHynXE7yFcU6amZ4H4GPZhhdboDt9l2iSDv/fCShymC0dl68UMmYnaiOWE/pleHaTpe2vY45oUEskVw9ymbT5x6htiA5C9prlV5VxSAw1D1BgeM+IJSL5F6N0PLMI6qJJpEcg2T6G9xefoJeRf58UwCX1OiYYXBV0a62VyR5VnQl8B3avl2ohp5jECllUcjT5mjOg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 06 Feb 2026 07:54:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHclpNYPLhzf1Jy6UKGKEMKa2gWarVz/LiAgAAD8oCAAU1iAA==
- Thread-topic: [PATCH v1] xen: Use MFLAGS for silent-mode detection
Hi Jan,
> On 5 Feb 2026, at 12:59, Bertrand Marquis <Bertrand.Marquis@xxxxxxx> wrote:
>
> Hi Jan,
>
>> On 5 Feb 2026, at 12:45, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>
>> On 05.02.2026 12:33, Bertrand Marquis wrote:
>>> GNU make 4.4+ exposes variable overrides in MAKEFLAGS after "--" (e.g.
>>> O=/path, FOO=bar). The silent-mode check searches for "s" and can match
>>> an override value, forcing silent output even without -s.
>>>
>>> Use MFLAGS for short options and filter out any long options before
>>> searching for "s". This preserves -s detection while avoiding false
>>> positives from overrides.
>>>
>>> Fixes: 4fdb4b71b152 ("xen/build: introduce if_changed and if_changed_rule")
>>
>> I don't think this is quite right: make 4.4 post-dates that commit by about
>> 2.5 years.
>
> True, we can remove the fixes tag.
>
>>
>>>
>>> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>>
>> Nit: No blank lines between tags, please.
>
> Ack
>
>>
>>> --- a/xen/Makefile
>>> +++ b/xen/Makefile
>>> @@ -113,10 +113,11 @@ else
>>> Q := @
>>> endif
>>>
>>> -# If the user is running make -s (silent mode), suppress echoing of
>>> -# commands
>>> -
>>> -ifneq ($(findstring s,$(filter-out --%,$(MAKEFLAGS))),)
>>> +# If the user is running make -s (silent mode), suppress echoing of
>>> commands.
>>> +# Use MFLAGS (short options only). MAKEFLAGS may include variable overrides
>>
>> Why "short options only"? It looks you mean to describe the macro here, not
>> what's done in the ifeq(); at the very least it can be read both ways.
>
> True should be.
> Filter short options from MFLAGS.
>
>>
>>> +# after “--” (GNU make greater than 4.4), which can contain an “s” and
>>> falsely
>>
>> 4.4 and newer really, as 4.4 itself is included in the affected range. I'm
>> not quite sure anyway whether the comment really needs to go this far. This
>> kind of detail can be had from the commit message of this change, if needed.
>>
>> Happy to make adjustments while committing, yet I'm not sure whether you
>> agree in all regards.
>
> Agree.
>
> If you agree and can do that on commit, i would just put:
>
> Filter short options from MFLAGS as MAKEFLAGS may include variable overrides.
Are you ok to give a reviewed-by and do the changes on commit or do you want me
to
push a v2 with those fixes ?
Cheers
Bertrand
|
