[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] xen: Use MFLAGS for silent-mode detection
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Thu, 5 Feb 2026 11:59:52 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=suse.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yzsWQja5xQytwL8IBW2sE1gAw6RtagMOQd7oWp97mjE=; b=XJvYbBx0taeZFEWPSUnok4A3LvCpnDWWnQRWmj2eE5jOhwU19Zp2cVmR7LrY8o7clfa1/ZSFF7Dos5XnXsG5yHWDdJ5o9330HxY0ot8/TYr5+1UTMMR1ej0n9eFIuwP/s+dNtTKNogeglABvHg8IxiIUZD7xGITIR9Ph1T95i0Mp80rL9Y6WIlGRWrim/wN1uYcM9ZT4eaM5ZBR0m3aUNQlayWurhyfXwxBsjb2qKJsj9FnB8sJjCTwavPQ3GyUtdjOCSbiPOvxuSB62ePdleCpwAxYw/s9e6MnXBwsVjEfwpZK7CIhT4wsE/d0s60jip4tEErMYjFJRfuHVW6rUvA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yzsWQja5xQytwL8IBW2sE1gAw6RtagMOQd7oWp97mjE=; b=VXBsq5hfs6w/00v18N2HIYiNR1xtHcVR0+6h3r5LNqyDURi4Olp1r/XDKgfU7tA/xXiBk9PTP/hJzN15qT8VGsR/dYNiia49VR5gJz20UVEDvQidyl8fm4L3Ht3AdkyQwvAbNQKJJ30wNoZuoumWPZbXNkeEmi+t6k47wczWIXI2t+5oGNTXVC7I6WEcVVlbfcqK8zZ7PFrgLcGCidjRWbwD5e/0m6PMMLYvkPml8tTKOy+vNbln8ZWuw7H7wuEIJewfrq2Dt2YsmgBuLJMw1AsV/Z9H7vDyjyGrPxYBtqxpxFGcUCYNY9Yox8tqgcslsHtxXfYJP4TWAilp07ieSA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=Rqfs+kgav9CWHSpv2zoouqj/t6g/UA922a5XXIejuX7cSWxsIxDnEXQ9ie/RCIKDduxyK9d+iyOSZKPYfj27+CwTSvMzQ6C5HHtfH70/eVq4BY0hIvCTo2a1GQ0PGI52zRkymMRitPs6exo4d5jfabZabLsh7F40cR0MaKT0Y2CX2zmxC3++Rf9MrzF9cdAqZ1Oqi8ZVAQc7hIszA8c5wLWFW4nL/ju1KeELHxrI0kteyUcm5S+j5+pLqAPAq4ClJRQd/PLZj+K69bu6zszoOrrSLSWysbb6wUQtiYFb9bnXUdky2Jkkc7WC8HOgVdw3q0nRejKNDoK5z1OyKDe2Pg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qdcjEXwwAp6jOx6xZzNUOCs1NaBYMKPwB0aR9OVCV3j8d474wCtYAosAWM0xYKZv36skEQNq2sg/MBC4xB+ueQTMgMHKRzKOhEcHd3BfmCUp9zwJ6jYDQwkOe1BsfHi/nrZ9INNfjCBaRRtYFADASFFgZWvf2/TfdQ85Xew5BQJ5EN7cyIPZYCh00HKsFXoq3c5nk1BxfNWyW+2A1o3hMq7OQY/Y71Q+npBsnkJjRNlfkJ3LeUWLH5vnuKlTx7dgEqWYj/sXuBTOYwMY+drBh936nWBYJWzchuanSFZYQyGaH4v/55Eu9S1XYSUcXsX5btDdvjQMIblyyGCJG+Ic8g==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 05 Feb 2026 12:01:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHclpNYPLhzf1Jy6UKGKEMKa2gWarVz/LiAgAAD8oA=
- Thread-topic: [PATCH v1] xen: Use MFLAGS for silent-mode detection
Hi Jan,
> On 5 Feb 2026, at 12:45, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 05.02.2026 12:33, Bertrand Marquis wrote:
>> GNU make 4.4+ exposes variable overrides in MAKEFLAGS after "--" (e.g.
>> O=/path, FOO=bar). The silent-mode check searches for "s" and can match
>> an override value, forcing silent output even without -s.
>>
>> Use MFLAGS for short options and filter out any long options before
>> searching for "s". This preserves -s detection while avoiding false
>> positives from overrides.
>>
>> Fixes: 4fdb4b71b152 ("xen/build: introduce if_changed and if_changed_rule")
>
> I don't think this is quite right: make 4.4 post-dates that commit by about
> 2.5 years.
True, we can remove the fixes tag.
>
>>
>> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>
> Nit: No blank lines between tags, please.
Ack
>
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -113,10 +113,11 @@ else
>> Q := @
>> endif
>>
>> -# If the user is running make -s (silent mode), suppress echoing of
>> -# commands
>> -
>> -ifneq ($(findstring s,$(filter-out --%,$(MAKEFLAGS))),)
>> +# If the user is running make -s (silent mode), suppress echoing of
>> commands.
>> +# Use MFLAGS (short options only). MAKEFLAGS may include variable overrides
>
> Why "short options only"? It looks you mean to describe the macro here, not
> what's done in the ifeq(); at the very least it can be read both ways.
True should be.
Filter short options from MFLAGS.
>
>> +# after “--” (GNU make greater than 4.4), which can contain an “s” and
>> falsely
>
> 4.4 and newer really, as 4.4 itself is included in the affected range. I'm
> not quite sure anyway whether the comment really needs to go this far. This
> kind of detail can be had from the commit message of this change, if needed.
>
> Happy to make adjustments while committing, yet I'm not sure whether you
> agree in all regards.
Agree.
If you agree and can do that on commit, i would just put:
Filter short options from MFLAGS as MAKEFLAGS may include variable overrides.
Cheers
Bertrand
>
> Jan
|
