[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: avoid Paths.mk in hypervisor build
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 4 Feb 2026 08:34:58 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=suse.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mLp6p/x+WMMVlG386HgFX8zvxq5M5ISiafLmRsagybY=; b=BtatWjH07S2MbXsPJWeO2zZrt7xJP525SlN5auQZfn9VECLBjeL64Z09dE57cJQA5ZDJM3moNX7nnUn7NebAY7AapUGzjCBuyY6QM/DfdGT9KwK7CbOqi4N6VgrblLM8PyEYaKs1u+bKpXd8YIeMNZjkBkAXm27dNzieqL4z29V+HpAwHsWiGr2DyWovJyAgQMuuiTPtUfdudTSiVlyfW//f4DqFp2cTaC5hu1nPRJIVad0TMyRekf13iR3W9u1tX/dckf08zjOeC+mg/sW9gNlgJesrdLVgi7RQCzgLtMLbkAmHu5PvBv/ryvktcrJurm/1YvvDfL7YJ+/FmTfMtg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mLp6p/x+WMMVlG386HgFX8zvxq5M5ISiafLmRsagybY=; b=h2YYGf1TjU3yP3yIDYNAMP2h2paZJemp7Se9p8PMr9fl+F6IsMhxYDNNTxUCsbMVEP0E0us+/x4XwSOBOpwdpPcPYTUxaSxcu3qMIDENObuQ1Qc7v1GYAWFQsnoC7+gg7MDiaa1cylME27BJaDuQid6vOgIWe8R1EFc2/Foq4nK1b6fppAhX74sbvs76kQs3qYEZmfa+G34iodAHcblH68Z6TWJMwqk3xh3cLfCuc+UbXR0g2wo3feOh3CqH8zQYVNBLD8E4jKkpp0Mlo3542Quv8izu2rOWcQmcBthsjydr7XKsrra136wQKf7rBswHp4k9/y7a6jTfyW/f1/I/6Q==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=b2RXaxfoFPSzsRz1ZLf1iwQM2POBBfxVn00BM+4xgqNk2idDZ2eQvEs4ql91ZsKh1vrAAho0uqCaudHFGRfL0XzY3CDfRt3LmrA5OMBakLmltgq3nlvJWdOVtiYxH3xPD6Jy5qHx/adtjIMyXl7pkmxi6bMoHdNb5CIRaL9NARTsDvtPuUqL+WtdXVc4ONlYfHrddIPoI/fWbhNfCWA4bAdylbGs1cl/mAiztF2DwQetRCYnrhgnWUq2SzDK+52WfGqD4JulWjJ2hwgoFzfR9owwbPvtugqdLFZBKh2YSazEu7OQ2WPja+o6xapgGqRFBf3KfZgwVBna604Pp+UTYQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LrDzLaF4B/OK1g/eSJ/FCRJLZZWuX1RT/n/8PHNnU5iTVpO9/p4q1FJVAOPwe7zRg0PhujXR+yKHBW9PG11tpkZ7d4yu08wkdEpF/t6aXd9VsCRpVMiW1/S8kHLNrmsPL3wTXdFPIuvffzb9sRSXJ3YNbOyOu6cnPA7Agun0CgazW2ZfsXazD2hTwDGTH3iHQD4JWXD+8iJ3WvsRpGAEjZ4hg0EcIgrkd7akEnfwx5NwltbsBpQQmv8SeZpinJMlk1rDqFxCZuRq2BBHsyYepM6X86wDvB4UbThj46DMW2swfxrKNhBRBp52llFk2Ox2JC6oZuCinbEG8W1uxylYTg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Wed, 04 Feb 2026 08:36:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHchV6cHH8qTLh8YEa40ejcvCxMQLVyV4CA
- Thread-topic: [PATCH] build: avoid Paths.mk in hypervisor build
Hi Jan,
> On 14 Jan 2026, at 15:03, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> Its inclusion placed where it is, it affects the hypervisor build as well.
> The hypervisor build, in its _install rule, uses $(DEBUG_DIR), first in
>
> [ -d "$(D)$(DEBUG_DIR)" ] || $(INSTALL_DIR) $(D)$(DEBUG_DIR)
>
> $(D) is an absolute directory (shorthand for $(DESTDIR)). $(DEBUG_DIR) as
> set by Paths.mk is, too. Both point into the build tree. The two simply
> shouldn't be glued together.
>
> Note that the earlier
>
> [ -d $(D)$(BOOT_DIR) ] || $(INSTALL_DIR) $(D)$(BOOT_DIR)
>
> continues to be working fine, as BOOT_DIR continues to be controlled by
> config/StdGNU.mk. Its DEBUG_DIR isn't taking effect anymore, when for the
> hypervisor build it should.
>
> And of course behavior now differs between building xen/ in a tree where
> tools/ was built before vs in an otherwise clean tree.
>
> Fixes: 82b9cc04a7c7 ("build: add make macro for making file from file.in")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
I did a bit more testing and checking and as far as i can tell this works.
As I am confident the cases i did not cover during my testing will be covered
by CI:
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
|
