[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: avoid Paths.mk in hypervisor build
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 3 Feb 2026 17:17:12 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=suse.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uE49mNU7o/f+UFRrp5Xw+T4iHWwq3t2m62iAvt7eISA=; b=TdQSBm/fYz5NefpzdBAqSmux/8zlxdQ1shNX9RSIYDw8rMcfuOdFdP181yHw01zQepLHjqFXF1FghYOu+TwIzbrSnuX8vZzt+eESjKDRR8Aw8rS0tUfgCdVhj8jiBbnnjlzOs2ZcSJYtZaaeXOjveQg9kPr3PuGNCzlBTxkvG3ygLc/jvDi/0nwiUcy925s4ouppUlJQfqw2haNaWFLaf7PPI8vjSClDPYh997tdNjhj0QpneK+7OOqiFdM+6keoZIVN2ldY548Gn+96lpgvKrHP4tYSjdc+6YOR0FtKEZLMM5lNWPfp8ahmT3ICmezJfe2G6C5jkd2qvfIUInldGg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uE49mNU7o/f+UFRrp5Xw+T4iHWwq3t2m62iAvt7eISA=; b=NUPvYjcrhsu+OkVv15n2m60Nn4SrLFv5ly3boVh8ROr6oqbMJHUFUsUaTAGmWNOydxHySf30cB/6jd10Kq+Fr9VmUtMgVxBMqzkOpvQXijb5Y8M8CY7mLLQ0I8KFAqGLuijF5yAMJcayToxEwNxmdbj9D+ZJUu3rajiV7j5WgUGN0Vo+EDa/ppN8AMo42IehPHjwpywvvQHsQ4F6MiJe13KnWuCsEQY90Xo0w7QrxAkqJlppRzhE4h3zzTVcIuwoumgkjMkcnWvg2NrUzA7Xtrkpp59d+5xBTo7DOCb+tU47wnqWz03Fb8zkbnZkgC9a3onkZDai+lRINS3WLypWLg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=rAtUcQ0X0TbP/mUxeMoZWJ9Mw1xtAo2WViPzPAnaBIWcNP4h5nITRYlvkq5uY5ukaV88UwgVwmfHto/C1kFWeMgXfOOTPolqA7jMr02PNUjqq1QUwtnUuJlN9SY8EpFaeyqP+wg+XKkgwkJWbzv/+NWOn7zOlEm7DUQcnZxUG9zqr8nbKeipiCxapHfciGp1s7Sqg/sKIMHlCczrvT3aOmJMzgw8UZ+3OLnkealip4c5nF02IgaWEsvOa31PMRJsIb6h2Atdp8PsVCwHkfA50TH2JTudw8bK1BBEUpxU61m6c5ecUJOlE27mYUZ4Pml+j1eSnojh7y8GtSbVaXjU1w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IiW8p0/mgzrs9F0AKcAV7wePf1CPqPJ0gmsaI2kvkuJcXAJiecbuFXfdKZL6wyj3lUDujhSglSz1BzC+PY6WLQ/XzWapaWdzRwaPe3PaK8gOBFMjnHJ0S+pK4fu9XDfCDI/H6cQKdUAfVwrMqrX4tTb0YCJJdszcnhmzgUU8Mqp2C9dYr2d6JM6rROxN38lXxFeXsXx8nH28b+v5g4qPRMo1ABjB8KzXw25ONxglGH0RLsiSaGrjz67mhShwlow5+NAuCEzAXcICG91JJMlWIT3BUI0s/pDPY0SRHKAWuZg6hlgIgxQrGhW7hVn19YizeLv7YI0lemTSKCQU2K1PfA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Tue, 03 Feb 2026 17:18:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHchV6cHH8qTLh8YEa40ejcvCxMQLVxVxSA
- Thread-topic: [PATCH] build: avoid Paths.mk in hypervisor build
Hi Jan,
> On 14 Jan 2026, at 15:03, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> Its inclusion placed where it is, it affects the hypervisor build as well.
> The hypervisor build, in its _install rule, uses $(DEBUG_DIR), first in
>
> [ -d "$(D)$(DEBUG_DIR)" ] || $(INSTALL_DIR) $(D)$(DEBUG_DIR)
>
> $(D) is an absolute directory (shorthand for $(DESTDIR)). $(DEBUG_DIR) as
> set by Paths.mk is, too. Both point into the build tree. The two simply
> shouldn't be glued together.
>
> Note that the earlier
>
> [ -d $(D)$(BOOT_DIR) ] || $(INSTALL_DIR) $(D)$(BOOT_DIR)
>
> continues to be working fine, as BOOT_DIR continues to be controlled by
> config/StdGNU.mk. Its DEBUG_DIR isn't taking effect anymore, when for the
> hypervisor build it should.
>
> And of course behavior now differs between building xen/ in a tree where
> tools/ was built before vs in an otherwise clean tree.
>
I cannot fully validate this but it seems to make sense so
> Fixes: 82b9cc04a7c7 ("build: add make macro for making file from file.in")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> This is clumsy, but I can't think of anything better. Suggestions anyone?
>
> --- a/Config.mk
> +++ b/Config.mk
> @@ -162,7 +162,9 @@ endef
> PATH_FILES := Paths.mk
> INC_FILES = $(foreach f, $(PATH_FILES), $(XEN_ROOT)/config/$(f))
>
> +ifndef XEN_FULLVERSION
> -include $(INC_FILES)
> +endif
>
> BUILD_MAKE_VARS = $(foreach f, $(PATH_FILES), $(shell awk '$$2 == ":=" {
> print $$1; }' $(XEN_ROOT)/config/$(f).in))
>
>
|
