[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Strange symbols_lookup() behaviour in test-symbols on arm64 CI



On Fri, Jan 16, 2026 at 3:50 PM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 16.01.2026 13:48, Mykola Kvach wrote:
> >> Actually, can you give the patch below a try? That would explain the 
> >> 24-byte
> >> difference (albeit I'm struggling with some other aspects of a proper
> >> explanation).
> >>
> >> --- a/xen/arch/arm/Makefile
> >> +++ b/xen/arch/arm/Makefile
> >> @@ -87,13 +87,13 @@ endif
> >>  $(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds
> >>         $(objtree)/tools/symbols $(all_symbols) --empty > $(dot-target).0.S
> >>         $(MAKE) $(build)=$(@D) $(dot-target).0.o
> >> -       $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds $< \
> >> +       $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds $< $(build_id_linker) \
> >>               $(dot-target).0.o -o $(dot-target).0
> >>         $(NM) -pa --format=sysv $(dot-target).0 \
> >>                 | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \
> >>                 > $(dot-target).1.S
> >>         $(MAKE) $(build)=$(@D) $(dot-target).1.o
> >> -       $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds $< \
> >> +       $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds $< $(build_id_linker) \
> >>             $(dot-target).1.o -o $(dot-target).1
> >>         $(NM) -pa --format=sysv $(dot-target).1 \
> >>                 | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \
> >
> > Thank you for fixing this issue.
> >
> > I tried the Makefile change you suggested (adding $(build_id_linker)
> > to the two $(LD) invocations.
> > With this patch applied, I no longer see the issue.
>
> May I translate this to Tested-by: then (confined to Arm, as the full patch
> touches PPC and RISC-V as well)?

Yes, I agree -- please add the Tested-by tag.

>
> Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.