Re: Strange symbols_lookup() behaviour in test-symbols on arm64 CI

[Mykola Kvach <xakep.amatop@xxxxxxxxx>]

Hi Jan,

> Actually, can you give the patch below a try? That would explain the 24-byte
> difference (albeit I'm struggling with some other aspects of a proper
> explanation).
>
> Jan
>
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -87,13 +87,13 @@ endif
>  $(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds
>         $(objtree)/tools/symbols $(all_symbols) --empty > $(dot-target).0.S
>         $(MAKE) $(build)=$(@D) $(dot-target).0.o
> -       $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds $< \
> +       $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds $< $(build_id_linker) \
>               $(dot-target).0.o -o $(dot-target).0
>         $(NM) -pa --format=sysv $(dot-target).0 \
>                 | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \
>                 > $(dot-target).1.S
>         $(MAKE) $(build)=$(@D) $(dot-target).1.o
> -       $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds $< \
> +       $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds $< $(build_id_linker) \
>             $(dot-target).1.o -o $(dot-target).1
>         $(NM) -pa --format=sysv $(dot-target).1 \
>                 | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \

Thank you for fixing this issue.

I tried the Makefile change you suggested (adding $(build_id_linker)
to the two $(LD) invocations.
With this patch applied, I no longer see the issue.

Artifacts (binaries):
https://gitlab.com/xen-project/people/mykola_kvach/xen/-/jobs/12743067337/artifacts/browse/binaries/

Test job:
https://gitlab.com/xen-project/people/mykola_kvach/xen/-/jobs/12743031743

Applied changes (last two commits):
https://gitlab.com/xen-project/people/mykola_kvach/xen/-/commits/reg_dbg1

Best regards,
Mykola