[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build/non-x86: fix symbol lookup in presence of build-id
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 16 Jan 2026 11:16:46 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+3jZvyi1+TRpa1wtyNUJlSDD43ttt2aBdW8nrRsEy7Y=; b=UZofZb8CBuw0KShjxrH1EWPcqtDUjrLhumzNBSRSRcT8jaDJHTiQTrpETsmDBdsv3aJiY62SguhF1KsgH4C73UW0yEfvQ0Q9fSzeTcxa9S9oYrwD9o4QWvJPiSLGP9pKWvndnlmc7vtj1Y41tUnhx1VBSQLJxK88VpkL4Rhbn9Yu+GwLZyTbTL5ru++8f48TIPWUkqpgVbdmofJm3wlIUBH3dUDjnDbGWbS3MIglUvygBTQPKxyjVaMMvN7A8hlsRyNC+pUccarQ1f3F6H5/CgPl9ydGIIph3nDao6Dt/W+M7D6QvrsGWm2uPRn1CsVIiaj4d2o6NPERmlGHTMOPhQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WiBSgz7pRuSLF1cyxWYeSG6G8LRGU2xDjmnj2PWHBA8nE9w4ZKvTF1HUEZdtK6c96BqZGA1mMO1BPTcBHEcpU3zDF5yLFbzgCgZO/4dceDQFHbTYW+No7DH3nTmmL/uxvirHtdjKNu7LoKRStK5OdeADZdfBmf5PayUQK2npMnI6aR2YC6l7EGOd+yGpAcrfe0s4cFO1sAubm6qF0KfA5glK51lrDXhboD9WjigGmzplRsvIFKt6u/b59UxtYFMnreRPyprafSIxEo8H4OljWxMtLga9AR/n6mmlxAUPVGSwMixHf42jMgdVtoOmNjvvGjdA7hK58UW++Byr67BEUg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Mykola Kvach <xakep.amatop@xxxxxxxxx>
- Delivery-date: Fri, 16 Jan 2026 11:17:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16/01/2026 10:52 am, Jan Beulich wrote:
> It's not clear why only x86 had $(build_id_linker) applied to all three
> linking passes. Not doing so will alter symbol offsets between the 2nd
> and 3rd passes for, potentially, all of the symbols at higher addresses
> (intermediate alignment padding may mask this effect, though, so it will
> look as if problems appeared randomly).
>
> Fixes: a353cab905af ("build_id: Provide ld-embedded build-ids")
> Reported-by: Mykola Kvach <xakep.amatop@xxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
We really need to make this step common between architectures. It's
entirely magic, but mostly common.
~Andrew
|
