[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/x86: Pass TPM ACPI table to PVH dom0


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Mon, 15 Dec 2025 09:13:51 -0500
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BN5GeH/d3wf/S3L0KfK6Vn3S2aK2/XrzNkj5xe4a8ho=; b=JwxWbn3uNerQIq+KqZ+dM8jBvDEC2iebTTkPrwvWhLxLUIVe1KK5sCI3K7+sy9ITCMfEl6kF0JAVQogjRH78zUYb/k9dq8xcd2Sz1i5IKd1/WWetSHJRrR4qFNqV/IxinA94sEKbcb10ns8U3W21KvQUvP3ONUez6NEyxjMLb4WtOUxSBrTf5dpZtzKPeJP3MA7GIVApzzbiP39umx6p7382ukcGQ0V7kKpOle8QVjBxzrMCs/zf1vyKlNybE7xtLXbzDd1Rzq3NZ+7pP0uto0QITb/+oeOKv2XXcr7Iy0uocg7YODC4VVP97DIC0Io4n/Q+pUP+luzQt5PWrH+Lfg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZbdDwErGSIjzvPbvT8pWvS654xT8JYeoW/BcsozctwtcuiIG4McXiRs6heCHMFmLpznoXR+QmNtJYzAj3smmNe76Fg6WzFaRH+dJmwbGNqTBOqx0tDmk/kimdhz++EQBZ/ZlC7Qg2ZqVUvSy0gE5DwE2aedD+ivpsJ17jbJE26Uil38x4cmIADbV/3PcSXnK0mCnm7m6ulF4ZTQMI/q8vqoP/MTpwOvdghGptdZcZTuvWCfEVOgdSHFlhiOx3qHxRztCY3OCg/PRAb5xVPchcBl1pGD+yKM/UZzLvSUPaCmdVr++4bhzZdBQNMkOJRiGwAD5KaSfmSzezyR3TFSNxA==
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 15 Dec 2025 14:14:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2025-12-15 04:46, Jan Beulich wrote:
On 12.12.2025 23:29, Jason Andryuk wrote:
Pass the TPM2 ACPI table so that the device can be found by a PVH dom0.

Otherwise dom0 shows:
tpm_tis MSFT0101:00: [Firmware Bug]: failed to get TPM2 ACPI table
tpm_tis MSFT0101:00: probe with driver tpm_tis failed with error -22

TCPA is "Trusted Computing Platform Alliance table", but it is really
the table for a TPM 1.2.  Use that as the comment as it's more
identifiable for readers.

Not sure about this particular aspect - this and ...

--- a/xen/include/acpi/actbl3.h
+++ b/xen/include/acpi/actbl3.h
@@ -78,8 +78,10 @@
  #define ACPI_SIG_CSRT           "CSRT"      /* Core System Resources Table */
  #define ACPI_SIG_MATR           "MATR"      /* Memory Address Translation 
Table */
  #define ACPI_SIG_MSDM           "MSDM"      /* Microsoft Data Management 
Table */
-#define ACPI_SIG_WPBT           "WPBT"       /* Windows Platform Binary Table 
*/
+#define ACPI_SIG_TCPA           "TCPA"       /* TPM 1.2 Table */
+#define ACPI_SIG_TPM2           "TPM2"       /* TPM 2.0 Table */

... the TPM2 comment bring us out of sync with what Linux has there.

I'm fine with copying these from the Linux version to keep them in sync. I should have realized this was an imported header when adding the entries.

Regards,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.