[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] xen/x86: Pass TPM ACPI table to PVH dom0


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Fri, 12 Dec 2025 17:29:49 -0500
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SHt93iO4Bir86TPYeBqDCrXpSjAw0WEGbKSHRnGDY7k=; b=s4REc3b5A4oUyHrmj3lSvYltTp6LRjsRhOJ6AHQ41P02Z1Jcq+flp7PjOfhtFQfuA7YrZwNXsc9AET8iE+9APKhOxq+oDY3Ap4Acjq5KEQA1FDS1ED6oJ7A3ScGAAmZ6YECeqHPO7mG17+UaOOLGdigKBmCUsclaEO0gMQ6820CGfQfyEXBWYs1X1j1by3cqliezQwJll9s7uKnGeFI4iy9A6NkcGp7IfBXx32fhjkUQSr+r7j0prmGO/qT5aJVFH6XFupLWBPEqtb8JGLv0FOmWT/H9cK8xWQJ5k57pS37JH3Kv5DHh5rRVMG44xv7kS76gpXMSDS8920rqrdJO2w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vDU8hHS28m1eVw5uuC8VnZaGVl3UmFtePs9HnkOfftetiTLQDBdhqu356oN6qMsD5e9tjcZiTaAqAxuss9ArX57u1/R6qVdZ9q7LLLVpMqOK7oluOLqlubed5nRrsZPoHXTuuPF6pRdOrZCriSoKKM4ZjMMgTElU0w00u0gDw+ZGSYgJTPK9v9gQICfraD+8c5kECfyu6zQ4PotNDpKV+Oha8GDXaB5pcPQqxE+iId7rRuzVOdaOi5lcIBMdPZEUljbSldt5GQUBswynBp+GClsiFNnqexA9ifdHZoPEipLp1x+l5c2054GffaYnef6J1yBqjx1VJCh3f9O6Nd1fKg==
  • Cc: Jason Andryuk <jason.andryuk@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Fri, 12 Dec 2025 22:30:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Pass the TPM2 ACPI table so that the device can be found by a PVH dom0.

Otherwise dom0 shows:
tpm_tis MSFT0101:00: [Firmware Bug]: failed to get TPM2 ACPI table
tpm_tis MSFT0101:00: probe with driver tpm_tis failed with error -22

TCPA is "Trusted Computing Platform Alliance table", but it is really
the table for a TPM 1.2.  Use that as the comment as it's more
identifiable for readers.

While doing this, move ACPI_SIG_WPBT to alpabetize the entries.

Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>
---
Only TPM2 has been tested.

AIUI, a TPM 1.2 is probed without the ACPI entry, so it is usable.
But since I know the table exists, I added it.
---
 xen/arch/x86/hvm/dom0_build.c | 2 +-
 xen/include/acpi/actbl3.h     | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c
index 5ac2cf8394..7eccadf7aa 100644
--- a/xen/arch/x86/hvm/dom0_build.c
+++ b/xen/arch/x86/hvm/dom0_build.c
@@ -1013,7 +1013,7 @@ static bool __init pvh_acpi_table_allowed(const char *sig,
         ACPI_SIG_DSDT, ACPI_SIG_FADT, ACPI_SIG_FACS, ACPI_SIG_PSDT,
         ACPI_SIG_SSDT, ACPI_SIG_SBST, ACPI_SIG_MCFG, ACPI_SIG_SLIC,
         ACPI_SIG_MSDM, ACPI_SIG_WDAT, ACPI_SIG_FPDT, ACPI_SIG_S3PT,
-        ACPI_SIG_VFCT,
+        ACPI_SIG_TCPA, ACPI_SIG_TPM2, ACPI_SIG_VFCT,
     };
     unsigned int i;
 
diff --git a/xen/include/acpi/actbl3.h b/xen/include/acpi/actbl3.h
index 6858d3e60f..b8db95a18b 100644
--- a/xen/include/acpi/actbl3.h
+++ b/xen/include/acpi/actbl3.h
@@ -78,8 +78,10 @@
 #define ACPI_SIG_CSRT           "CSRT" /* Core System Resources Table */
 #define ACPI_SIG_MATR           "MATR" /* Memory Address Translation Table */
 #define ACPI_SIG_MSDM           "MSDM" /* Microsoft Data Management Table */
-#define ACPI_SIG_WPBT           "WPBT" /* Windows Platform Binary Table */
+#define ACPI_SIG_TCPA           "TCPA" /* TPM 1.2 Table */
+#define ACPI_SIG_TPM2           "TPM2" /* TPM 2.0 Table */
 #define ACPI_SIG_VFCT           "VFCT" /* AMD Video BIOS */
+#define ACPI_SIG_WPBT           "WPBT" /* Windows Platform Binary Table */
 
 /*
  * All tables must be byte-packed to match the ACPI specification, since
-- 
2.52.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.