[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/x86: Pass TPM ACPI table to PVH dom0
- To: Jason Andryuk <jason.andryuk@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 12 Dec 2025 22:38:36 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XKxoDeCLIIv4KuqdgwkOoCM77j3A0fZ5TNsr5D/DBAs=; b=jFih39WwRcPgp3FIaaMFGmkneQZan/U1LeGYEQXx4CDHp2XyqydBwb21BcvEjGcbp50V89jaYMVlBCSJ2s3sT6qh4owp1iA/cyeIR6fPQ4tNNon0V/Cc10Nzure6+DrrBL5Y8fy423k1p9XNUJAHkOPzJJHTT8leWRnjQ+37nPiZkTYOaNG6KeN4jBb8t/FpX9hkF7eykgzmGdZMkU/KUi1XVi1e5JBE0P+m9NuSakct/5wWF4QgxSjhj7s4tIDWOslDZLCuiVYW2G3UYhCebjdrJB4YdsNj/VW5ZdK8GmQKkpHcUC2fGsXVjPArGseWboLn2z1ctwIfJRWdJkoDcA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ju9yW6IKlmtkTJggnwIaRgD3LAVBiXBcHhG6RDftfL+eSLdzqog66Ov8xFTlbXyCfQjI6taOPYySF8HKmaXqmN5gfpGV78O6l1g8fqsI8L4+wIi2i2xrcxBtU5t8oY8NJhHtciJRvViMBVZM8sMcdrLswfsyaNLc+YwyyRb6IrgnnKWv8W4vmep5aDNAM/X/HF+VYVZ1DfJrobUJIl+NUqbUtDUndBkeWBpBrYlYvmmu15NuQ4+zAIGcpu5AreqcHtXRghEj15GWoGx0urPJM/yWB1I4L5XbdVUAFt7ZG6lfrW9HejAaa1SxuRU+mTUgOd3eVBGoX9bHh/z40t+Wrg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Daniel Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>, "krystian.hebel@xxxxxxxxx" <krystian.hebel@xxxxxxxxx>, Sergii Dmytruk <sergii.dmytruk@xxxxxxxxx>, Ross Philipson <ross.philipson@xxxxxxxxxx>
- Delivery-date: Fri, 12 Dec 2025 22:38:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12/12/2025 10:29 pm, Jason Andryuk wrote:
> Pass the TPM2 ACPI table so that the device can be found by a PVH dom0.
>
> Otherwise dom0 shows:
> tpm_tis MSFT0101:00: [Firmware Bug]: failed to get TPM2 ACPI table
> tpm_tis MSFT0101:00: probe with driver tpm_tis failed with error -22
>
> TCPA is "Trusted Computing Platform Alliance table", but it is really
> the table for a TPM 1.2. Use that as the comment as it's more
> identifiable for readers.
>
> While doing this, move ACPI_SIG_WPBT to alpabetize the entries.
It's probably worth stating that this brings PVH dom0 more in line with
PV dom0.
> Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> Only TPM2 has been tested.
>
> AIUI, a TPM 1.2 is probed without the ACPI entry, so it is usable.
> But since I know the table exists, I added it.
Yeah - I'd have asked you to do this if you hadn't already.
That said, it highlights that the Trenchboot series needs to grow the
ability to hide the TPM from dom0, both the APCI tables and blind probing.
I presume that tboot already does this, because I'm sure it's been
tested, right...?
~Andrew
|
