[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/5] x86/pv: Address MISRA C:2012 Rule 4.1
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Sat, 13 Dec 2025 07:52:06 +0100
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1765608726; h=DKIM-Signature:MIME-Version:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=6B0h6GcE1DzTz+ueOBRGU0cA7XtqcKZu7VR6ldWdmnE=; b=47qi4WoPPiv0RE2VmeD8dkeX2GBqCZI+9TSabVZReBg0rjc52j+L0EK4tcqX5t8RUC6L 99uT9ehkAp53M8SRLEeq+sfPCK7NFfoY3d3dksw/fCyeze/GFy9ojo7CMNBGUqvelNcL1 aujY+pXw8R65xCMtCaLdcB6+Cnbm6B9+nOb5jHeKaNiU/BHj2SLPyyTAGUEnjojFQcdaq ggyUC9X2Dh3JgZ2xfeDkAv7sqPJsNsxI1T30XEohyZT8e9/2+WCN6Lymva3yKx/9bgcRm A7S8fmT/dCHs1LpCX8Z5U/PtzvIxpK33eiA16jFafuC9RSH5iyQY7K95C9YpJM6ff9ETs sNvGDv6lf6TQZ0ivf4aCw721GET9QVxK0/peO8YPFPukRkVTR8nRAnJSFGtFuOi7jA2ez EcfsF1iHDC0Nw0Qty9xpf8gpWjXxS5axnl6THrom9TwqvRtq9DINvPMSNqEXEcdKHLlMa D3gX0UeQFm6teT9xB3qIWewYY5rvbpnt7/1Ld8ighFNVv2h1TJAERJAvAiSp4t9swMxhf CEvT/vjAqI2ca9tJEdUMWSBzoTWfViqTiQcJGf8+1Gb479JW5jUQ4yyf0sppE96hnbAP8 lWrCV7ttR5SR4wmc+j5t6nknnatwxznXNsjeAyArhYGKdfbIKZWkhpyGNT8HhqE=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1765608726; b=3xY0sUr0OOhD9U3KEFIP449sBL95zxAPi++AYzcj0hyu/th6oWo/FKdX785q4co15UW+ 3QHmkwXqP84381cLV+BMBYe+bF4le8jrU0T1MqY7eTdt8ArIW+muDQwXBrGr5zePM68VL dD5Yh7Ah4dNvVwAIhi/E0aMcdbSVJLa83kY4yahBhfwm9P0TlU2lBcB8G0Fc+6DOLIoKm 2qgOvf9udJLcKa9V+zoXYmpb6QaIEd1wYqqZ0aw5jvoWNRAmbBLZCJOLLMZ7l79BTywVu RjD00Pg8CPu6NXEsURlBD5Te/dau87YT8nrXHq2UevGsOXbCZ0VmCoAoZZ1cFA1wWjqtN 14ZMw7vlwfLPOYCB48j04KR5biCmcRVeGOcHzg1Bp1l4/7RMB/Yd7RpWEbc3B/AJN0Xxd bKfqq7/hLFSzUehXmiBvc4BjZMt6WUjIbi/xFBSJfa6F10+O5C0shttKPlr+eE/SulbrU YhcUrDpVreFeG4uzme3+OK5QWmfhm5UjxDYXp0N4szYnuuheHwfuZ9UI7HRY5d6rCa9D1 g0/zjBzWVXfHqxlLmloM3uPCbhlr5Sw9HPcy1LpXxAxubxbgxc1rumprskAq/3+TVf1lM Ysabw54bKVch6tAP42W5BWWA9W+Ev/ME7ymZJCdVP5JEP1bDRWR9vRrsI4E0fP4=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "consulting @ bugseng . com" <consulting@xxxxxxxxxxx>
- Delivery-date: Sat, 13 Dec 2025 06:52:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-12-12 23:20, Andrew Cooper wrote:
MISRA doesn't like mixing hexadecimal escape sequences with ASCII text.
Use
the same workaround as in commit cd5048353725 ("xen: address MISRA
C:2012 Rule
4.1").
No functional change.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
CC: consulting@xxxxxxxxxxx <consulting@xxxxxxxxxxx>
CC: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
xen/arch/x86/pv/emul-inv-op.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/pv/emul-inv-op.c
b/xen/arch/x86/pv/emul-inv-op.c
index 314ebd01cb34..346ac1124d7b 100644
--- a/xen/arch/x86/pv/emul-inv-op.c
+++ b/xen/arch/x86/pv/emul-inv-op.c
@@ -26,7 +26,7 @@ static int emulate_forced_invalid_op(struct
cpu_user_regs *regs)
pv_inject_page_fault(0, eip + sizeof(sig) - rc);
return EXCRET_fault_fixed;
}
- if ( memcmp(sig, "\xf\xbxen", sizeof(sig)) )
+ if ( memcmp(sig, "\xf\xb" "xen", sizeof(sig)) )
return 0;
eip += sizeof(sig);
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|