[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] xen: Centralize scheduler linker definition
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Wed, 10 Dec 2025 11:49:14 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dE1wPnvndGFxY46NPEZk1yugpaOagy3WdNTA+mwjpmM=; b=TjhemlgXm2rPJR1DOJbUc/EJFFPN8A5jk31jMq6Rnt45mewIL+1XiIvro+OH+6vLW0+niwo8tIuVAjtNHOEjoy357D30tvfAhbdroddpO8GiFg4EsC1t/AQDRTfy/7VoPhD2lwcxup0A1NPICppcuOfvCg8XQhvljuLJz7V48DOYiMU/JQPO2a320WPf9vxZeO0QDpz1JtZOqQyoeDfMzkwFKYHoZL7uKVsZlfT2UwfiSvAs53sVTzQfVYW4FsRys3zLm3us2oUIlqM5pUnb/zBrWeZe16gtIByPBHCg5lcyhdxWFH6FMTsOqN72zeQUX3TU2XvAkiAoMQfIqfaOvg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RstK2kT4OmMipvxKkCa/spFJT/HuVHpEpt2wnNqKDj3oXoKH6NYefuZFjYPAFmkrdbsFfPB6igA23ecb3NFHlAfhwdi9W6yiodpNx092WZYDGEBPhh63QGgG+zP3ia6/mQZyJbHat4PUSmCOk7us33OF1zRCyuffDIYD6b+QgaafScCxiFSa3yYu+7qF6MRb6vMFFAYmMiG6lbyiD+fs7FVmGe/VZpr5c0ixp/0wDvweLHldCLc4eWrQ/Q2sfB0ILUycKi/ccWpAgWOVZFtsZ3VzyPNtXl6QtzYSvKSQ/2UfkVWSQCEQNUnS5nMCjWtpm0tJR4/MsgB6uhq93zw2jA==
- Cc: Victor Lira <victorm.lira@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, "Oleksii Kurochko" <oleksii.kurochko@xxxxxxxxx>, Grygorii Strashko <grygorii_strashko@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 10 Dec 2025 16:49:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-12-10 11:32, Andrew Cooper wrote:
On 10/12/2025 8:08 am, Jan Beulich wrote:
On 09.12.2025 22:47, Jason Andryuk wrote:
--- a/xen/include/xen/xen.lds.h
+++ b/xen/include/xen/xen.lds.h
@@ -173,6 +173,12 @@
_edevice = .; \
} :text
+#define SCHEDULER_ARRAY \
+ . = ALIGN(8); \
While indeed it was 8 in all original locations, I question that for Arm32
(and a possible future RV32, for example); imo it wants to be ...
+ __start_schedulers_array = .; \
+ *(.data.schedulers) \
+ __end_schedulers_array = .;
+
#ifdef CONFIG_HYPFS
#define HYPFS_PARAM \
. = ALIGN(POINTER_ALIGN); \
... exactly like this. Preferably with that change (happy to carry out while
committing, alongside a respective addition to the description, so long as
there's agreement):
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
I thought the same. struct scheduler is entirely pointers, and one
unsigned int.
I'm pretty sure that this "array" predates the introduction of
POINTER_ALIGN.
So yes, with it converted to POINTER_ALIGN, Reviewed-by: Andrew Cooper
<andrew.cooper3@xxxxxxxxxx>
Converting to POINTER_ALIGN works for me.
Thanks,
Jason
|
