[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] xen: Centralize scheduler linker definition
- To: Jan Beulich <jbeulich@xxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 10 Dec 2025 16:32:36 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=80APy/Q6P1tgxbZs/fBHK9IV82q93Hp9MtbGhEDy+p0=; b=UHz1lMOBj3l6I/ptN8LeyZ4yp651yMlfN7XPWXAbf4jWNANRs4THzEmrK6IKkB7xTRCfaUs7GV9mgftKAMjEwQWRO9yY4xGD90Q1wRQVjg87T8GwqoAXl/uKWO2f9xAsYaIdA5FNIW42K+930OvqaSZSmcmUOPnwIUrEUORNTXq0Qx0N5dH3Kfu1n6qH3TpuKHYVYUrmZ4fPMwu8vVJXpWhwHf85qP5m5f+vGF9jKxJYGSQWKKgWa5kjSPTiInlg2W4sui9DTbgXoHtebSdsn95OKXp4TRfnz2YJVmqeuiMIQ/4siWO7vRX/448NYnXuGNTh1MZRGuSZC4LqP8TZXA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xJtXwlBh5x0Go0aXs2A4kg1CqibOL5nuYzW2djEy4fUDCLHRFaDyApZ//S5qtCTy/v8bh620NSW1T+h+q9m3CcWVS9zSgAmTD/0itYG5bCoI3TMYO2prKL3UcZ1RmvBn5B4O/n7h2aPQGDjF3uuKEl4hTyxvFjSXpcd4wUdxXDiusOJhHsmeFIoKBBo/6zbe0iFlT/LbKf3JGRxGgP84KSSql+wRRzWzwTxHRiuZvrxcXP0YKQzxcGLU+OABmaSYSpuHclmU09DhFe6DRxuBOBMgP5nzH+nHkq47x6tB0DzOHTF9fAd6GJpxX2Bn9zK+YYQUtt9QLi4YnqXhUHygFg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Victor Lira <victorm.lira@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Grygorii Strashko <grygorii_strashko@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 10 Dec 2025 16:33:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/12/2025 8:08 am, Jan Beulich wrote:
> On 09.12.2025 22:47, Jason Andryuk wrote:
>> --- a/xen/include/xen/xen.lds.h
>> +++ b/xen/include/xen/xen.lds.h
>> @@ -173,6 +173,12 @@
>> _edevice = .; \
>> } :text
>>
>> +#define SCHEDULER_ARRAY \
>> + . = ALIGN(8); \
> While indeed it was 8 in all original locations, I question that for Arm32
> (and a possible future RV32, for example); imo it wants to be ...
>
>> + __start_schedulers_array = .; \
>> + *(.data.schedulers) \
>> + __end_schedulers_array = .;
>> +
>> #ifdef CONFIG_HYPFS
>> #define HYPFS_PARAM \
>> . = ALIGN(POINTER_ALIGN); \
> ... exactly like this. Preferably with that change (happy to carry out while
> committing, alongside a respective addition to the description, so long as
> there's agreement):
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
I thought the same. struct scheduler is entirely pointers, and one
unsigned int.
I'm pretty sure that this "array" predates the introduction of
POINTER_ALIGN.
So yes, with it converted to POINTER_ALIGN, Reviewed-by: Andrew Cooper
<andrew.cooper3@xxxxxxxxxx>
|
