[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Set ThumbEE as not present in PFR0
- To: "Orzel, Michal" <Michal.Orzel@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 9 Dec 2025 10:47:04 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k9KoBxccSWB3/hnf1bKUsSDoEfA0C6+2JdJw9KFyMkM=; b=HVyUJzVToVX1zhhpmxE1MWbPgTc+4UFoa3/QkLDlap7hT4g1JqhaSeQBFCksXbAYYcYlVtsKV2TS4Zf1b/WV1k68x2EGNl2DhA5rPXotskOmRt/hKS2TLFCHiIiWTrX8pWX8tW4q+aMZFWh9tMuHwLK2WiOQ0uWWt/s2g704+fW2+4ppUrezElaY7ysR3VETJMDa+JrAL4Muyh9nWtRCDEyVw1PlDtBrEbLXsJp3rpmfNN1Ff9GKp2G1AoOZ5LsmPn7thHqKdMM14kzVc3OJWA/3nndHy0Vo5hl5Nx+SeVZt9fN3BaNAgZnHvBfvP2AHlRldabj8cw/ka+MxUuvpCg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k9KoBxccSWB3/hnf1bKUsSDoEfA0C6+2JdJw9KFyMkM=; b=oXbq13Db6hewKFB/VT6pyUWUa0aQ8r5zFTOZbzUW87DW/spUTLTIXNPtMiuM+YZiHqPfnyXNHByZfmwj+jM8E08H7rx+6tEBhIPcRBWdXIA3Rsbwzmzg2ud36vtUpKCHF0+zaLXo/rH+ZTMEkYWcNDBeRe+i4feJXpUou6ZUqaLgNnaEf9AO79Wk79iwRNWrQ+WZA2GoibZ878/FDqjL8rfwCRLB0avDTC+KBYxe3nhr3ahhQ45pjCWCzJuT1UYLoG2zFjjK6zo3ubP+ptkWulTi/j+NAfhsUJwZ6VfjeI7xcie+bCyPvKO8c4s+JQGCOP+RnAbUn0kofQHbQECnYQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=kDK8vclbXjDRh+S3gi7g8BesS6D0y3FWsKEh6xz6MQNgOstEqHgjateXK+j7p0aa/Af0zM/ljYVEz+bJ3nA7wWWXfsgr2a57T9gemgcb4At4DaaTjib7gp6BQiXJLMsE7S1flEy/aNb1GfboFwr/kP8eYTSpe4QVMfHL/RxfqyZ1GWBIu5mSsA9anoTrz1u3rKAOzLBthmxX8o1RmBhhl9XqddRkmPef8fX3asZB+lRs7GjIsZxwHquSHT1YXL1xb8TYq9RgAXQTPKaLT4uAzQEtUDMzU6IOJadMoiL49y9CxZqi/dVn3fLCUhXaSEQK/WBXdERlO5A0beGmb6bcXw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QKiCGLPjtGmjTTuUuZMmlVkRwf4/jKMKHo66xqrELLfY1LQJNKq2OEBaQUX3kICauLQA8nNXhr6uJmZXJo3VoW69zVo75C44PfvXvpNui0f8tS33qxRwN/7iVxRmgrYFHpq5IyL3RiDLwF6NhoGdIuQ9jb8U2l3mrold+O/SYVAaU7v8GGODPszXMBNDoYwgV7n+L8F+XjLaSA1zDWct3lxpxSI9rOLpThGNwr803jUsXfKSysTh2tEcQ9pJpfrBfvg2B/PdNDof3jYjIQivJIwgjfw/kAib9TLTN8IaumswTQq/+XP0gNPdcHigFhZ/6iyGB6d25C0wGbUJPdlJ+w==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 09 Dec 2025 10:48:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcaPfxR2UFZeCxt0WCBuHK00zE1rUZHyaAgAABLIA=
- Thread-topic: [PATCH] xen/arm: Set ThumbEE as not present in PFR0
Hi Michal,
> On 9 Dec 2025, at 10:42, Orzel, Michal <Michal.Orzel@xxxxxxx> wrote:
>
>
>
> On 09/12/2025 11:37, Bertrand Marquis wrote:
>> Force ThumbEE support to not available in the version of the PFR0
>> register value we present to guest.
>> Xen does not support ThumbEE and will trap all access to ThumbEE
>> registers so do not report it being supported if the hardware supports
>> it.
>>
>> Fixes: 5bbe1fe413f9 ("ARM: Drop ThumbEE support")
>> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>> ---
>> xen/arch/arm/cpufeature.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c
>> index 1a80738571e3..4cde208e721a 100644
>> --- a/xen/arch/arm/cpufeature.c
>> +++ b/xen/arch/arm/cpufeature.c
>> @@ -225,6 +225,7 @@ static int __init create_domain_cpuinfo(void)
>> #ifdef CONFIG_ARM_64
>> domain_cpuinfo.pfr64.amu = 0;
>> #endif
>> + domain_cpuinfo.pfr32.thumbee = 0;
> Let's not split AMU section. Also, it looks like a convention here to add a
> comment about feature we disabled. With:
>
> /* Hide ThumbEE support */
> domain_cpuinfo.pfr32.thumbee = 0;
>
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>
Ack, happy if you fix that on commit.
> that could be done on commit.
>
> Do you have a pipeline link?
https://gitlab.com/xen-project/people/bmarquis/xen-ffa-research/-/pipelines/2204086293
Cheers
Bertrand
|
