[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Set ThumbEE as not present in PFR0
- To: Bertrand Marquis <bertrand.marquis@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Tue, 9 Dec 2025 11:42:41 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZOevnLtBHKOc4v/CbKgN2Q0ADAYGKTP0fsSB3dprXic=; b=tzRrqGid4Emg3jMuLyUaMp78g7M/gEZ9LsA6Se9jkUt8m2bSDofdppUO9blqXgr3whZl+p8lKzOA3dtdqgV++BtnN6l+DQXMzc8J8+OXXfZBkCDT7buaFK5Tf6FcrKDM/NnkEzh0d63uBnGlv6wxz4GFB+Srn4/QpVmCeAz2eoDR22+Shq/4I9lczPLx0wgC374S9g/3S80YrST0GlG90j+jHu/aEBHEvZOQT6joCM9eLeF+zh8dUXgXCe66JiMSzhEDKB4RVM9xY6JeWUI1IbIEWpfS96OvBe0bvlyIIhvvjtdnALJR6bigFkV7QZ1syxJ7vPm3G9qZsJeHpPrtVQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=f27g2U2w+5ZlVlAmTDyv4+ewj8qhi2B0rSLss6gYle3TUS2nLvBeJWYEop2ocZqAP5qK8MTBqIgAzoXC93FZuOTAWMSJXqRyQJH9yfbGzRxfveTUdoxxjHZYnpG+ZzLKkZHcrKAjfnNNyT51bPHwK4jDccBfpD12igBiwNSosOmuP54Bj1P6tZbwMt6wb7oG7uIBuzA9h1BGj+Zs17Cu0Pj6hnSvdL0yRaYAZvGf8eRwjzbarij6DyfUIJOm2w54arYQn+U5PIaLSR2Dv7VLn+m6beuswYpZyIg7b9g2lsY5b8oQPM8N/h66kYAwgTbFQgr/nveijtDAYEdAjE3KCA==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 09 Dec 2025 10:42:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09/12/2025 11:37, Bertrand Marquis wrote:
> Force ThumbEE support to not available in the version of the PFR0
> register value we present to guest.
> Xen does not support ThumbEE and will trap all access to ThumbEE
> registers so do not report it being supported if the hardware supports
> it.
>
> Fixes: 5bbe1fe413f9 ("ARM: Drop ThumbEE support")
> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
> ---
> xen/arch/arm/cpufeature.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c
> index 1a80738571e3..4cde208e721a 100644
> --- a/xen/arch/arm/cpufeature.c
> +++ b/xen/arch/arm/cpufeature.c
> @@ -225,6 +225,7 @@ static int __init create_domain_cpuinfo(void)
> #ifdef CONFIG_ARM_64
> domain_cpuinfo.pfr64.amu = 0;
> #endif
> + domain_cpuinfo.pfr32.thumbee = 0;
Let's not split AMU section. Also, it looks like a convention here to add a
comment about feature we disabled. With:
/* Hide ThumbEE support */
domain_cpuinfo.pfr32.thumbee = 0;
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
that could be done on commit.
Do you have a pipeline link?
~Michal
> domain_cpuinfo.pfr32.amu = 0;
>
> /* Hide RAS support as Xen does not support it */
|
