[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 3/4] domctl: Provide appropriate error code when VM events are not supported


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Milan Djokic <milan_djokic@xxxxxxxx>
  • Date: Fri, 5 Dec 2025 20:36:50 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5yMP3Tz77lZyIHFAGIFCclXZDcQr3lxGx6rzXnYKPZs=; b=BpHfM9XR/egSMquInMoIYCYtdN5m0kabhrqnT/xIy4qkh23E176gJKuiHu1XqZ0qglhZkpTAue8wK5XUpbNMQeGw+QKg1JevWi0QSGAzVuC+DS3bHjNayBbYujLFtcuepCDwacF9N+yuUA24ZtuFspr9fws+MgLdmhBqDPX6a5bP1td0PCC2UHvPbAdavem3mxunWd1mjt55QBhJhwZNk+DvaPYKUe3mnBrxFvkdSZoY+/F419apbLP//JlRRPfMTnz6hedP+mhW5AwZNPXqYvnidNRfvcRO5XTsEYg61i9BsmS5xPQ5Mx5+FloMDpBKIFJtbiwMMXbgZpTNZyqn/Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xHxFJcxGFBQDpY+56liR25hKkQ1H5lmAfXFWiFL5i2dEgYvcalX4EOXWHi1mzqDouhEmFFjbVmz7ov5xkP5hNYcR8cdvL0VPUSplSRjJxksBdGe53eTedLsUcWeNiZhOrOxzutcebt1PrsMcYwnsgw3f97Z+/CRHgWtB8atQFCxk8ZjzKZ2zZGQJgz91P9pDGBPMbQsCeZ0k9f3FOY0PoNS+zcDl9pWnQh8hxY5+6SD9ql1Z9+EwvMfSY/gzrmG55VL/tiUqncHMpE1sLYUEhFkGVW4qbZ5Y4hUrAVXb5uZtD9HUsFbo2YU73u2D1zXhwr0egEM7a8YZee+7oY0Klg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: Milan Djokic <milan_djokic@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Fri, 05 Dec 2025 20:36:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHcZibiNA76ACBTxUmW3HNmbMMsdQ==
  • Thread-topic: [PATCH 3/4] domctl: Provide appropriate error code when VM events are not supported

Return -EOPNOTSUPP when XEN_DOMCTL_set_access_required command is invoked
while VM events and monitoring support is disabled.

Signed-off-by: Milan Djokic <milan_djokic@xxxxxxxx>
---
 xen/common/domctl.c | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 159864bc99..5284524b42 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -787,19 +787,22 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) 
u_domctl)
             copyback = true;
         break;
 
-#ifdef CONFIG_VM_EVENT
     case XEN_DOMCTL_set_access_required:
-        if ( unlikely(current->domain == d) ) /* no domain_pause() */
-            ret = -EPERM;
+        if ( !IS_ENABLED(CONFIG_VM_EVENT) )
+            ret = -EOPNOTSUPP;
         else
         {
-            domain_pause(d);
-            arch_p2m_set_access_required(d,
-                op->u.access_required.access_required);
-            domain_unpause(d);
+            if ( unlikely(current->domain == d) ) /* no domain_pause() */
+                ret = -EPERM;
+            else
+            {
+                domain_pause(d);
+                arch_p2m_set_access_required(d,
+                    op->u.access_required.access_required);
+                domain_unpause(d);
+            }
         }
         break;
-#endif
 
     case XEN_DOMCTL_set_virq_handler:
         ret = set_global_virq_handler(d, op->u.set_virq_handler.virq);
-- 
2.43.0



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.