[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 0/4] Align handling of domctl/sysctl unsupported commands


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Milan Djokic <milan_djokic@xxxxxxxx>
  • Date: Fri, 5 Dec 2025 20:36:31 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RA5BhbhYY4M/JOIT3p9VQwyw3l0aCB7jasnjvH8F6Xk=; b=LRa+oGqKLHoYboaVVyyWNhExx7jVozv51IdmOR7UVwplOOGuU79WLJF9yph7IwnrAbfQItdS1JO5O4B6mOQY9wpI6uTeROr5dJTM+MCrkEUV/gCY8B3ObZSrBvx9mBkUyahQKl23rrxiWQw5vqoh6pl98bZ+xdyV7ixbjvxbvyEeMRoSoiG/i3ZJ9ff5UgUznj8FSRBASjd6/E3V9TteX3iEn9kVOdVfngjmmjWCMpwm+hkbSa1UX8JTL8hfPq3nrM7AupqRMCtUu3yUCKVPWyeFWuq2UfgmyYW2Y44ctfJ6bu+uc5z2nLR6CunPBi5TDSld4gKXUY5Hq8fowNVdxA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CdIyAYJ292A9DvCHtLkfRCP9fjUu8lKLZYPRkk32B7NvYx7mz0dLVNw21ddyjMNxB5pqQ1csUTqCY0zeQWhV/WrvLWMsjnC3Fk8OwSZcxyFCwGcz9kN9PrIwQMWdeYUqYAYtVwufNNk4xMPPrz/HyVMV95RD/+7dv2sWHnyTr6X7H8g5Xi4ARbKiRGz/Bjfyf1JKjd6fAlCajgAn1jsVgwww1XbTPAx/WP4UfcrRhmbBffOwOK9Ltxrxpm9OI3jeUoWEwnU/nvYsxg+jFE1haTFYLKjdpnV/VAzzkkIFAPfhmOODfowNFfakl65IbKI62q28yO6sI1VuH5+DCSC+Rw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: Milan Djokic <milan_djokic@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
  • Delivery-date: Fri, 05 Dec 2025 20:36:55 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHcZibWGCY4W4S370OKBLIMh6NLpw==
  • Thread-topic: [PATCH 0/4] Align handling of domctl/sysctl unsupported commands

This patch series provides minor updates to the domctl and sysctl handling
of unsupported commands. Currently the behavior diverges: some commands
return -EOPNOTSUPP, while others fall back to the generic -ENOSYS.  
This series aligns the behavior so that unsupported commands consistently
return the appropriate error code, allowing the control domain to correctly
identify unsupported operations.

Where possible, IS_ENABLED() is used to detect disabled commands at compile
time, enabling dead code elimination.  For commands where stubs are
provided, the stub functions are updated to return the correct error code.

The only exception is XEN_DOMCTL_irq_permission, which cannot use
IS_ENABLED() due to PIRQ-specific structures being unavailable when PIRQ
support is off.  In this case, classic #ifdef blocks remain in
place.

There may be future updates in this regard. This initial series is intended to 
get maintainers' feedback on the approach taken.

Milan Djokic (4):
  arm/domain: Update SBSA_VUART_CONSOLE config option handling
  domctl: Provide appropriate error code when PIRQs are not supported
  domctl: Provide appropriate error code when VM events are not
    supported
  sysctl: align handling of unsupported commands

 xen/arch/arm/dom0less-build.c     |  4 ++++
 xen/arch/arm/domctl.c             |  3 +++
 xen/arch/arm/include/asm/vpl011.h |  2 +-
 xen/common/domctl.c               | 25 ++++++++++++++---------
 xen/common/sysctl.c               | 34 ++++++++++++++++++-------------
 xen/include/xen/livepatch.h       |  2 +-
 xen/include/xen/perfc.h           |  4 +++-
 xen/include/xen/spinlock.h        |  6 +++---
 xen/include/xen/trace.h           |  2 +-
 xen/include/xsm/dummy.h           |  4 ++--
 xen/include/xsm/xsm.h             |  6 ++++--
 xen/xsm/dummy.c                   |  2 ++
 xen/xsm/flask/hooks.c             |  5 ++++-
 13 files changed, 63 insertions(+), 36 deletions(-)

-- 
2.43.0



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.