[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH] coverage: add extended coverage capabilities
- To: Grygorii Strashko <grygorii_strashko@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 4 Dec 2025 11:56:16 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=979AaQTcNswXGon7Uw2M8iFwHq2O8Juo8snw4GX3V/E=; b=GRt3dfeValXOaGcPa1RyJBxZJhBMW3bP4+eQZQq/K9jsMFLLCGC0z9QnbtifEY+IuWhvJWjxpfjAHUB411p1UCjZ1LaAkHf7xkIWq/kXQX8oI32phGHBgCUReeDIranIiavXA7U1mcB23g57W8VDXuGFIAWWgdXcqzQAWvS9JW0S2S3UVnOME9k2xaqldr+xRcKUnyhfaM0bpT49AVTG2fLoqSOb34WWyBWlUeUEhm+jmu1PagaNsF1mEAPpVtGr3DiAhqOY/IftrqHJ6ZwCER+2hY3UaMVhauvWwOOuYaWR98LprXnvKuQcyMnGngrmhpra25PU5m3e3x0e9fXSDQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VzsL0l81LTU8ddtEs/gy24G/+W0ckwVbgjKmIJUN0xOukNJhDcz+jsXcncDlknjMk/jJC3R/FEeA7jx4F2yhpsvD3UeBF2EvpsQtTvL549VhCZMIGFq6xLq0yjiAhg+gGfgZf3RqkbyBXdMGSuV0i9DPbcUxftiHeA5gDogUwW/nsMSXJPtgel/NUyeWQEVmGJFnr6ck3Air1f8EYEfoA3HLLDuM/kQ3BIwK4ui9VH4nbHCdM1Kd+CheLnK82D+SByb5iL3/zhsK5n7BXYSiD4/qsjoR0xmV/p03amMcsXNPohezXGQ70IxxOc/VJN1hIMS+A2zLFFozvbSQCK7pGg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: andrew.cooper3@xxxxxxxxxx, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, Victor Lira <victorm.lira@xxxxxxx>
- Delivery-date: Thu, 04 Dec 2025 11:56:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04/12/2025 11:00 am, Grygorii Strashko wrote:
> Hi Andrew,
>
> On 04.12.25 12:02, Andrew Cooper wrote:
>> On 03/12/2025 10:24 pm, Grygorii Strashko wrote:
>>> From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
>>>
>>> Added CONFIG_COVERAGE_EXTENDED to enable coverage for .init and lib
>>> code.
>>> When enabled - Xen .init data will not be freed.
>>>
>>> Signed-off-by: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
>>> ---
>>> xen/Kconfig.debug | 10 ++++++++++
>>> xen/Rules.mk | 13 +++++++++++++
>>> xen/arch/arm/setup.c | 2 ++
>>> xen/arch/x86/setup.c | 4 ++++
>>> xen/common/libelf/Makefile | 4 +++-
>>> xen/common/libfdt/Makefile | 4 +++-
>>> 6 files changed, 35 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
>>> index d900d926c555..3e04e1a3992b 100644
>>> --- a/xen/Kconfig.debug
>>> +++ b/xen/Kconfig.debug
>>> @@ -44,6 +44,16 @@ config COVERAGE
>>> If unsure, say N here.
>>> +config COVERAGE_EXTENDED
>>> + bool "Extended Code coverage support"
>>> + depends on COVERAGE
>>> + default y
>>> + help
>>> + Enable Extended code coverage support which include .init and
>>> libs code.
>>> + The .init sections are not freed in this case.
>>> +
>>> + If unsure, say N here.
>>
>> IMO this is unhelpful. Noone wants to opt for the model we've got right
>> now.
>>
>> Instead, I think we want:
>>
>> config RELAX_INIT_CHECK
>> bool
>>
>> and have CONFIG_COVERAGE select it. There's no need for any user
>> visible option here.
>>
>
> So It will be always enabled if CONFIG_COVERAGE=y, Right?
Correct.
Now I come to think of it, IIRC UBSAN is also excluded on init objects
for related reasons. (At a later point), we can see about giving it a
similar treatment.
~Andrew
|
