[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN][PATCH] coverage: add extended coverage capabilities


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
  • Date: Thu, 4 Dec 2025 13:00:07 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rgtDeA3zaJ+xMRiXlr+vBIfPXVeV264YSu8ULpZ6lpY=; b=SOJUcIvr5MutHpHygcLFamuFVKA6ue03PbKJvuzCjG8FbEVanjkuPFonD76zaFGOT4FIDhbPDrxio+EevID3bU+TBaG+oPMKyMhdQq7AN8C7idf2B3RtbfBwtQFbu24GrKoxS2nGEsZci7NyFze3QSiDtyQKixd1zDw4jedn/2lCiqxdTRjiwPorYQsWKeQ1cuaQdr7HDc6pf04XVaAzSuhpksNooUPAiEeFGeWotMOk8WpGiDt0s/zJu8A+fwtb/Ep7SUOnV9bRRz5HTuVdRn2peoT8pbq2MbhLfNplkj+JcypCz9sCf4vFEG5jcy8L9J7caXd7ha08CQq569Yp4Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xTUIPvP/4MRD/tU0Zx0cf7OWJ6qdVHbo4ukg+H1C978R5YGrsufMe17yv2oZqUJHiOcm5SAVztJ7OYaX8R5bdj4//yRwAUsiqMSawP7PJ6pkTpIz9ovdKSdPYzp3XOhxJdlr0U90zIjmFo7+pRrK0D1cUbYYBcd4hONeVF4ewLvpV08LQXoRmjLrxyRU4AK59IutcsW9Qyl89kcWqvoZcX7FQY8liNym15w4sqpubXXrEvG4KJhTaosMn0M++yGCjwgku4XoVWxLai8HSjoQFX/+qy93SUVvywZT9GqOkvse1fMbIRXV37fHJyOzEElJaGeUkAbqfJQJfV/4UPY0qw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, Victor Lira <victorm.lira@xxxxxxx>
  • Delivery-date: Thu, 04 Dec 2025 11:00:22 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Andrew,

On 04.12.25 12:02, Andrew Cooper wrote:
On 03/12/2025 10:24 pm, Grygorii Strashko wrote:
From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>

Added CONFIG_COVERAGE_EXTENDED to enable coverage for .init and lib code.
When enabled - Xen .init data will not be freed.

Signed-off-by: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
---
  xen/Kconfig.debug          | 10 ++++++++++
  xen/Rules.mk               | 13 +++++++++++++
  xen/arch/arm/setup.c       |  2 ++
  xen/arch/x86/setup.c       |  4 ++++
  xen/common/libelf/Makefile |  4 +++-
  xen/common/libfdt/Makefile |  4 +++-
  6 files changed, 35 insertions(+), 2 deletions(-)

diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
index d900d926c555..3e04e1a3992b 100644
--- a/xen/Kconfig.debug
+++ b/xen/Kconfig.debug
@@ -44,6 +44,16 @@ config COVERAGE
If unsure, say N here. +config COVERAGE_EXTENDED
+    bool "Extended Code coverage support"
+    depends on COVERAGE
+    default y
+    help
+      Enable Extended code coverage support which include .init and libs code.
+      The .init sections are not freed in this case.
+
+      If unsure, say N here.

IMO this is unhelpful.  Noone wants to opt for the model we've got right
now.

Instead, I think we want:

config RELAX_INIT_CHECK
     bool

and have CONFIG_COVERAGE select it.  There's no need for any user
visible option here.


So It will be always enabled if CONFIG_COVERAGE=y, Right?



--
Best regards,
-grygorii




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.