Re: [PATCH 1/4] xen/xsm: address violations of MISRA C rules 8.3 and 7.2

["Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>]

On 11/20/25 2:32 PM, Nicola Vetrini wrote:
> Rule 8.3 states: Function types shall be in prototype form
> with named parameters.
>
> add parameter to 'has_xsm_magic' to make it consistent with the
> definition.
>
> Rule 7.2 states: A `u' or `U' suffix shall be applied to all
> integer constants that are represented in an unsigned type.
>
> add missing `U' to both #define for `XSM_MAGIC` for consistency.
>
> No functional change.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxx>
> ---
>   xen/include/xsm/xsm.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
> index 9a23d2827c..074d61cd45 100644
> --- a/xen/include/xsm/xsm.h
> +++ b/xen/include/xsm/xsm.h
> @@ -22,9 +22,9 @@
>   typedef uint32_t xsm_magic_t;
>   
>   #ifdef CONFIG_XSM_FLASK
> -#define XSM_MAGIC 0xf97cff8c
> +#define XSM_MAGIC 0xf97cff8cU
>   #else
> -#define XSM_MAGIC 0x0
> +#define XSM_MAGIC 0x0U
>   #endif
>   
>   /*
> @@ -815,7 +815,7 @@ int xsm_multiboot_policy_init(
>    */
>   int xsm_dt_init(void);
>   int xsm_dt_policy_init(void **policy_buffer, size_t *policy_size);
> -bool has_xsm_magic(paddr_t);
> +bool has_xsm_magic(paddr_t start);
>   #endif
>   
>   void xsm_fixup_ops(struct xsm_ops *ops);
Acked-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>