[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.21 5/6] tools/xl: fix possible uninitialized usage in printf_info()
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Wed, 15 Oct 2025 14:53:15 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rVS9Ul4zzTnSSr/oEUy3mV/MwN732/dLn+kt5CUVyP8=; b=Itmt2ZCcoY34ulgpxcgajgwHl2I6B/f3Zxrj0iGOIc+G+EypyIEhlAXzrpvaMPGex+Bf7a6YUYd4y3rEeQLbe8XWcBWFyKIINKxZXhPwGeCbQnbT+lOOcXq+0B+lExsulB27hYt8Z/KglFqgwkz08cvcOZXiXthkx7kzevA2534SSsAfs/v9yUbWPQ+t9/aiHNudXksigDELXKvhO75hzK8nCxj7uPxel+AljvDH6dhzqjV+MG9zXQ0jrp4moRfrp/XeQtI23BEG+d0aST7Dkn3EmGs8PvE3p8kkNHe5hfW138T0ntsabaGPj7pIZfSZx0icqW152dMssEtUj4ix5Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nOUEgkhuEYvVGQZkggDRwjt38B0tbUJii0JLfXjGbHaA6xQJtEHFb7kEa1s4Bo174swjeBS/jZiaxPY3lU8iPxXkRy7Fa4cAWire+9E+7KhJDISet4it/UUxUuSUETNZjgLwqm2P0+VryNEsW65fsaFFSLOjgs1kGjIWC5WzIVW/EICjKWpC23PN5fmjDkdjRPOeTMdDwIwhFuGM6F3c4RTk3P9TLTZfg82cfUD/EsLo5+nuvaQotgRD3QCzz9YxPcHgGAoMic0d+Tm5AeqVbm9OGU6oA7VJu6hNHu1tGlP1ON88NQYe93LH5HxOj489NYRiG6x5hG0V9irJsgwRNw==
- Cc: <oleksii.kurochko@xxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Wed, 15 Oct 2025 18:53:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-10-15 09:40, Roger Pau Monne wrote:
printf_info_one_json() won't initialize the passed jso_r parameter on
error, and hence the usage in printf_info() needs prior initialization,
otherwise an uninitialized pointer is passed to json_object_put() on
failure.
Reported by the internal XenServer Coverity instance.
Fixes: f6c6f2679d49 ("libxl: Convert libxl__object_to_json() to json-c")
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
|
