[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v3 17/28] xen/domctl: wrap vcpu_affinity_domctl() with CONFIG_MGMT_HYPERCALLS


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Penny Zheng <Penny.Zheng@xxxxxxx>
  • Date: Mon, 13 Oct 2025 18:15:29 +0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6tX06dash+GtYajn/b5K12INPH/R8TWFIax5WrG4+MA=; b=dRHvpiUnh6E2NwpnkiYWPMafk9noNr5szAFsB0h5gIBmiNpB4qlapC3VgazD+Uytk6Rk9m/VKyF5J9FqYAD2UvxQyu+MVDDSqRXssAHlpqsciNcBCGDwJT0GUkl6/dGRv6YKqiJdzLMMtyPBc4tPXcxQD3NXvm/cFpcFn9fxc4JVvzhOhfDZx9Md5qpxWHHAEvvX/VrDrtQNhn3oGNgzbdMvBM+OUToYZbUGetmJEEoX5+28SmeHo0rBGWAgTjDN1tqAL1wiXMP1sggf5TacCCP4DBtlGDcKfeCWzDkmQSFXJC42Bmv7nrG60h139H+533DiUFxSkVYe8aCijocvNA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wtCwgnpjddVNchvciwercwRn30bU7UO8J77GsaBNIIOtc+Mc3Kx7ymhpcopweYCxxIS+1AI1dqvxmVIC3Ro1ULzePglI4THAqhtonDzd2zVihArTp2uRrtFk+p1ye8aQEm12YspFwphTpJgIZzB6kqhRAUqGoZu9BF1ZXsly1bLk3D9WXhszjGIYwCEABE7KKR4LhXFsDqjHBenAPcy5ROH3opa7AJkCBjJq4HETAjrwdsrQaXleCmBNY4hnyfYClj9X4OC4a8HrzEEyDLRz+NYMP7ITnUBx9IuJrgS3p60JoHSUekYVX+CJ8ivZim7+GFoJojzKvB7QqP5Op8jDHQ==
  • Cc: <ray.huang@xxxxxxx>, <oleksii.kurochko@xxxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <gwd@xxxxxxxxxxxxxx>
  • Delivery-date: Mon, 13 Oct 2025 10:26:59 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Function vcpu_affinity_domctl() is responsible for
XEN_DOMCTL_{getvcpuaffinity,setvcpuaffinity} domctl-op, and shall be
wrapped with CONFIG_MGMT_HYPERCALLS. Otherwise it will become unreachable
codes when MGMT_HYPERCALLS=n, and hence violating Misra rule 2.1.

Signed-off-by: Penny Zheng <Penny.Zheng@xxxxxxx>
---
v1 -> v2:
- adapt to changes of "unify DOMCTL to MGMT_HYPERCALLS"
- wrap XEN_DOMCTL_{getvcpuaffinity,setvcpuaffinity}-case transiently
---
v2 -> v3:
- adapt to changes of "remove vcpu_set_soft_affinity()"
- address "violating Misra rule 2.1" in commit message
- remove transient wrapping around 
XEN_DOMCTL_{getvcpuaffinity,setvcpuaffinity}-case
---
 xen/common/sched/core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 88150432c3..180de784fa 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -1688,6 +1688,7 @@ int vcpuaffinity_params_invalid(const struct 
xen_domctl_vcpuaffinity *vcpuaff)
             guest_handle_is_null(vcpuaff->cpumap_soft.bitmap));
 }
 
+#ifdef CONFIG_MGMT_HYPERCALLS
 int vcpu_affinity_domctl(struct domain *d, uint32_t cmd,
                          struct xen_domctl_vcpuaffinity *vcpuaff)
 {
@@ -1798,6 +1799,7 @@ int vcpu_affinity_domctl(struct domain *d, uint32_t cmd,
 
     return ret;
 }
+#endif /* CONFIG_MGMT_HYPERCALLS */
 
 bool alloc_affinity_masks(struct affinity_masks *affinity)
 {
-- 
2.34.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.