[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.21??? 2/3] x86/vLAPIC: drop VLAPIC_VERSION
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 10 Oct 2025 15:52:11 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iRsbWzZh6NWmanuGC6yLuMnE8VsKm8UEG2Uo5cuBanA=; b=XoXE2bYbE4AT5bsgB9CI/0rcBU6PtZv830rJYt+NuQGdBzfHnpGdlS4UYP7Nj+cyVLUNIgowvLKm01JqvQaXUnX6mgOULyFX7fSxp42DHZe+OF71cH79GFkMxy//VhSRTTyQWogkj1rdAHjPriqvEfoYMIW8uAoWS6N+mrJt+uEPdHvRoqZqPb7p9RoA3unhKFiwav2wHOFV3ahf4CeXqw+kZ0VkV8kkpI+QLjy8PP0bBroGNSO8X3JQo5HuvtXrjTwwuGW55PejEwKAqwfAKR9tykfCsXAgQU4AxhL2kS9S1yv5UbkEnBvdLkTuGvq6mTKfpUNYf4pXeLgJCsh9zA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kn5IP+DqaMXyfnMWEB5VmSJE0HTV9LxmatzAcwYtmBuUUKrAm4+nSdEIxu7IY3buqZBIHuYYLAv4yJ9tq8Jtp1na4yWde2OjkKgATeHqtgimhbvZ9sSDTo3+Z7mg98sSE/K1QkpQSx6FmXzxBUarjl1Xpdl3XExbegk78p1vRw5I9QFoTEmDF5QWmDMtagpcJfDSaGXfXttsnGHNq7CdD2qPCBmtCk3USIYSqUxjnspdiMhq6EWglwgV/oVoWaB/gD86sv651v9vML2xixdCwKvvh4QZfDA7EtFG6AkrwH9qqeHgocw5gr4fSHgON2K/hyrkM1J/LPxyKmwjrPMpvw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Andrew Cooper <amc96@xxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Grygorii Strashko <grygorii_strashko@xxxxxxxx>
- Delivery-date: Fri, 10 Oct 2025 13:52:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Oct 09, 2025 at 09:21:32AM +0200, Jan Beulich wrote:
> On 08.10.2025 18:23, Roger Pau Monné wrote:
> > On Wed, Oct 08, 2025 at 02:08:48PM +0200, Jan Beulich wrote:
> >> @@ -1439,7 +1438,7 @@ static void vlapic_do_init(struct vlapic
> >> if ( !has_vlapic(vlapic_vcpu(vlapic)->domain) )
> >> return;
> >>
> >> - vlapic_set_reg(vlapic, APIC_LVR, VLAPIC_VERSION);
> >> + vlapic_set_reg(vlapic, APIC_LVR, 0x00050014);
> >
> > (Maybe I'm getting ahead of patch 3, as I haven't looked yet)
> >
> > Don't we want to use some kind of macros to build this in a more
> > friendly way?
> >
> > We could have a pair of SET_APIC_{VERSION,MAXLVT}()?
>
> With what patch 3 does to apicdef.h, I was rather wondering whether to simply
> use two MASK_INSR() here (patch 3 already uses one right now).
That would be fine for me.
Thanks, Roger.
|
