[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/1] tools/libs/light: fix BAR memory address truncation


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jiqian Chen <Jiqian.Chen@xxxxxxx>
  • Date: Fri, 10 Oct 2025 16:00:29 +0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I4X1/7P+8VcqxUR9Kb4zK033MtKsJ1/alb1zAlA3PB8=; b=uZMX3B0C6mfa/RvgmiAtOI3aRTekJwhC6m2iAi82Ls0/tuT3uM4gnQHIA9AVeaKm9Uut+DXMuHtSCIP+49OAxAMcrqjznMWdq14dnEbtq2N3OwwGhpmPQyqwTj+hY2j0q411dK+xhh1zdXLRsOzBde6hRN2S7hCEBJVoumJiXSYi0/ysKJR7Szd2Wv0qSGWX/tTO+r0okqMGV9jefT1LVJZQi470zrd1m2T5Yn/X307LRJujeue6VKxOLXsUF+IkIu/QNMioBI/oZXUuUThaAyTq1qdlAOVHWZzdyEptsVLwwxAM+fflumOJ+AagxTgiAiaW2PPDHL+jvvU8B4rqtg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KBH0aGdONFqZq2xeyGfG9SwRe822Y4MOEecIdym0B5RMn3aYD8PTvKzZfEP8dO4W5LVWRRm8O05Fr8bN4GE2hQVe1HKlrHrSc+/z1JJXhnYmRM8Ozr5c5psevTzIleqH27abQWme4HE2UITUaMO1kCmxj0mdLVg0mr6Qb4kyObaFYRxzWJaVix/dSI+iwoRswUKz/XSwrePQWZ6Do31UfolH6yEi5TIKTVa4CNi8Yx9C8fjoThO0qQ8Bek9fIXhmIRAcmI1PfjVvJHbZRJ1G3MF/zxr5nlvnhISMgCS2wNNJcW2uvWGWgTXuJatIiobU+TuA6AIx8es5voFTloDOLg==
  • Cc: Huang Rui <ray.huang@xxxxxxx>, Jiqian Chen <Jiqian.Chen@xxxxxxx>, "Anthony PERARD" <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "Oleksii Kurochko" <oleksii.kurochko@xxxxxxxxx>
  • Delivery-date: Fri, 10 Oct 2025 08:01:13 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

64-bit BAR memory address is truncated when removing a passthrough pci
device from guest since it uses "unsigned int".

So, change to use "unsigned long long" to fix this problem.

Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
---
cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>
cc: Juergen Gross <jgross@xxxxxxxx>
cc: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
---
 tools/libs/light/libxl_pci.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
index 2ea2caeb6624..88ffbbf08abe 100644
--- a/tools/libs/light/libxl_pci.c
+++ b/tools/libs/light/libxl_pci.c
@@ -2001,7 +2001,8 @@ static void pci_remove_detached(libxl__egc *egc,
 {
     STATE_AO_GC(prs->aodev->ao);
     libxl_ctx *ctx = libxl__gc_owner(gc);
-    unsigned int start = 0, end = 0, flags = 0, size = 0, irq = 0;
+    unsigned long long start = 0, end = 0, flags = 0, size = 0;
+    unsigned int irq = 0;
     int i, stubdomid = 0;
     const char *sysfs_path;
     FILE *f;
@@ -2031,7 +2032,7 @@ static void pci_remove_detached(libxl__egc *egc,
     }
 
     for (i = 0; i < PROC_PCI_NUM_RESOURCES; i++) {
-        if (fscanf(f, "0x%x 0x%x 0x%x\n", &start, &end, &flags) != 3)
+        if (fscanf(f, "0x%llx 0x%llx 0x%llx\n", &start, &end, &flags) != 3)
             continue;
         size = end - start + 1;
         if (start) {
@@ -2040,7 +2041,7 @@ static void pci_remove_detached(libxl__egc *egc,
                                                  size, 0);
                 if (rc < 0)
                     LOGED(ERROR, domid,
-                          "xc_domain_ioport_permission error 0x%x/0x%x",
+                          "xc_domain_ioport_permission error 0x%llx/0x%llx",
                           start,
                           size);
             } else {
@@ -2050,7 +2051,7 @@ static void pci_remove_detached(libxl__egc *egc,
                                                 0);
                 if (rc < 0)
                     LOGED(ERROR, domid,
-                          "xc_domain_iomem_permission error 0x%x/0x%x",
+                          "xc_domain_iomem_permission error 0x%llx/0x%llx",
                           start,
                           size);
             }
-- 
2.34.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.