[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.21] cirrus-ci: add json-c for libxl dependency
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 8 Oct 2025 09:29:05 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wTOYEjl64LRlQYAvP9+I1/dWcT5YwcVafHk4fHRCjfE=; b=ZOf7XnLlebBV2nKLS6kF/bopO7RqopsmA7UY2JYu/vKRI5VRd2WEJxBiULpFUHQsYy3sIKMwlt5DEs2kKJQqQconT1vi0VXRBu2r03BrLiMDvirWu3Oj3AXOfe6bizte4X8HqgOx6N0nfCQjGMTOcdlPeaD5H1cJEh0oKY5p//8l+/RsErg23YsyRuKv+j0mKv6mRKuLgqeFFml2bJTNoV+UkPOyJPm5q9DtS5Wfp0TvHnHQpt9eNfnwUg69s9I78zdHXLEo33yOPQHIHQAfVCcFGlnbtVlvE3EPZ2x9Rky5RbsS1lc4NXyZm9C676J7Yr3Y8cAi0hsmK/fPX+5HVA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=a1XGDwrdGj6GuMW3x+dR4UpwOilgQzFkPq7xjPywFGOdAdU2vSnRTU5nh8PG1ODOxF1U9wmGacvlRiQ/wwrfZJlVHDxhmF+QdHmQC+y16Essm7QVkdwzFQ4aFKu81VTZgXJzJH8Y1pahgiCeo7lXip3yDsyTcECv2XrOrmzijs+ZNWYCJ1KHU1/UMZfer6hYnszR+ISV2Et3tOr1vm03ZdbgYnkDyZDQZqbvG9PP1UGYBNGr34hS6b2tJ9p5+ciKDs8ixe9oJSTNzu36+FL7bpOh0bDXfwj29ydx/GgsNVnqZj2NwuNYN8UTubXt52c+pJazredfNFnVXtqPMC6Wyg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, oleksii.kurochko@xxxxxxxxx, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Wed, 08 Oct 2025 07:29:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Oct 07, 2025 at 06:06:45PM +0100, Andrew Cooper wrote:
> On 07/10/2025 5:13 pm, Roger Pau Monne wrote:
> > Add json-c package for libxl usage. At the same time drop YAJL.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> > Would be nice to have for 4.21, so that we test with json-c instead of
> > YAJL. I plan to switch the FreeBSD Xen port use json-c for 4.21.
> >
> > All seems fine:
> >
> > https://cirrus-ci.com/build/5366905441091584
> > ---
> > .cirrus.yml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/.cirrus.yml b/.cirrus.yml
> > index 7df7ff552222..0de1012d8c60 100644
> > --- a/.cirrus.yml
> > +++ b/.cirrus.yml
> > @@ -50,7 +50,7 @@ task:
> >
> > install_script: pkg install -y seabios gmake ninja bash
> > pkgconf bison perl5
> > - yajl lzo2 pixman argp-standalone
> > + json-c lzo2 pixman argp-standalone
> > libxml2 glib git python3 libinotify
> >
> > configure_script:
>
>
> Comparing before and after, we've got:
>
> - yajl: 2.1.0
>
> - Number of packages to be installed: 27
> + Number of packages to be installed: 26
>
> So, json-c seems to be in the base image, but even that points to it
> being a more popular library and the right way for Xen to be moving.
My bet (I haven't checked) is that it's also used by the cloud init
scripts that are packed in gcloud images used by Cirrus-CI. It's not
part of the base (non-cloud) images AFAICT.
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Thanks, Roger.
|
