[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] MAINTAINERS: Add myself as an AMD SVM & IOMMU reviewer


  • To: Jason Andryuk <jason.andryuk@xxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Wed, 8 Oct 2025 09:23:40 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0bJ6VGME2X1pZ3YqeVy1cb2BxBzpYBMiv86AsJg8Qrw=; b=kB9TafZeb0fe5DHgIPrKsj/ZfowjbYm6BLzLduETFv3lwEWnp6pHu1kodDJiv1UoC4+6QPflt42/7G/Wuiw9hDIz4nQbxVRhHayvbijZU9x84mei06K7cN4EqbdV7sBjhV5xfpZBQosbJePeVSEUtsenWbXt3BdWIi5mHOXa5TWJ/MuYbuRYs5zFrf2alq4H1nGHeWXdawK3+7A1a4M9ZfpKuB0+xEzBxlWtVT6diGVpvahN8B++2qFICGJsBVdV5phhYGVXwpJ1LR7mPBWylgNjOdHVeyqBP0u0u5lWKcpHYVKPl0LC3WudnK7ei6lNT+SuE+st0TTiRjAdM+hBKQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=On9N/Wf7YoU0gx/qyQmTd4H8aFyNsWTTreFWYaq5W7/gMg/Ab+HFLf1REuRA3LY2/HHGSri5CFGvCncro2Icl0E0XnEivskxCx3H7J2TaQagBB0yZ6RMzD83bD+ZYvtEGnj8V6d0miiLWvhiRByt6rIrOJFTiI7V0FY6z3CtodeDBy6aFxGiTc5djLAY5zNj03qoyRfifSKg78SDL9Mpw7QPoMNLGXWy+49BentyPiOBaDn3UMCD+Iw8jt/fXsLRq+oHWWm5pcYI7ZRl45D/7SldVzawCiH6uM4yI3uMnn/P8ycm7V26ka2eecwikkD1wmCp173AQjPlmI5jl+FhEg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Anthony PERARD <anthony@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Wed, 08 Oct 2025 07:23:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Oct 07, 2025 at 07:49:37PM -0400, Jason Andryuk wrote:
> On 2025-10-03 05:20, Anthony PERARD wrote:
> > On Fri, Oct 03, 2025 at 10:09:31AM +0200, Roger Pau Monné wrote:
> > > On Thu, Oct 02, 2025 at 07:42:38PM -0400, Jason Andryuk wrote:
> > > > @@ -601,7 +618,8 @@ M:  Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > > >   S:    Supported
> > > >   L:    xen-devel@xxxxxxxxxxxxxxxxxxxx
> > > >   F:    xen/arch/x86/
> > > > -F:     xen/drivers/passthrough/amd/
> > > > +X:     xen/arch/x86/hvm/svm/
> > > > +X:     xen/arch/x86/cpu/vpmu_amd.c
> > > 
> > > Would it be possible to not exclude the SVM related code here, and
> > > avoid having to duplicate the x86 maintainers on the AMD entries?
> > > 
> > > Or the parsing of the file doesn't deal with multiple entries possibly
> > > covering the same files?
> > 
> > ./get_maintainer.pl can deal with a file been covered by multiple
> > entries, there's multiple example of that already, (e.g. many subsection
> > are also covered by TOOLSTACK).
> > 
> > The exclusion is likely unnecessary, and ./get_maintainer.pl will just
> > get the information (email, ...) from every sections that a file match.
> > But the duplication is necessary due to the "The meaning of nesting"
> > described in the MAINTAINERS file.
> 
> Roger, are you okay with this approach?
> 
> I considered adding myself to the top level X86 entry but it covers so much.
> I mainly care about one cpu vendor ;) and I'm not interested in PV or
> shadow.  So I went with adding myself to the specific subset.

Indeed.  Jan reported a sorting issue, you can add my:

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

To the correctly sorted patch.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.